Addressed pr feedback (#42)

* Fix typo in finishedAdditions variable name in BaseStorageManager

* Commit transaction after sorting items in getTodos method

* Simplify toggleTodo method by using update for completion status

* Fix sorting order comment in getTodos method for clarity

Author: issackjohn

experimental/javascript-wc-indexeddb/dist/src/storage/base-storage-manager.js

@@ -7,7 +7,7 @@ class BaseStorageManager {
         this.dbName = "todoDB";
         this.storeName = "todos";
         this.db = null;
-        this.finishedAddtions = 0;
+        this.finishedAdditions = 0;
         this.finishedToggles = 0;
         this.finishedDeletions = 0;
         this.initDB().then(() => {

experimental/javascript-wc-indexeddb/dist/src/storage/dexieDB-manager.js

@@ -51,14 +51,7 @@ class DexieDBManager extends BaseStorageManager {
         this._ensureDbConnection();
 
         this.db.todos
-            .get(itemNumber)
-            .then((todoItem) => {
-                if (!todoItem)
-                    throw new Error(`Todo item with itemNumber '${itemNumber}' not found`);
-
-                todoItem.completed = completed;
-                return this.db.todos.put(todoItem);
-            })
+            .update(itemNumber, {completed: completed})
             .then(() => {
                 this._handleToggleComplete();
             })

experimental/javascript-wc-indexeddb/dist/src/storage/indexedDB-manager.js

@@ -89,9 +89,10 @@ class IndexedDBManager extends BaseStorageManager {
                     itemsProcessed++;
                     cursor.continue(); // Move to next item
                 } else {
-                    // We're done - sort items by itemNumber in descending order
-                    // for proper display order (newest to oldest)
+                    // We're done - sort items by itemNumber in ascending order
+                    // for proper display order (oldest to newest)
                     items.sort((a, b) => a.itemNumber - b.itemNumber);
+                    transaction.commit();
                     resolve(items);
                 }
             };

experimental/javascript-wc-indexeddb/src/storage/base-storage-manager.js

@@ -7,7 +7,7 @@ class BaseStorageManager {
         this.dbName = "todoDB";
         this.storeName = "todos";
         this.db = null;
-        this.finishedAddtions = 0;
+        this.finishedAdditions = 0;
         this.finishedToggles = 0;
         this.finishedDeletions = 0;
         this.initDB().then(() => {

experimental/javascript-wc-indexeddb/src/storage/dexieDB-manager.js

@@ -51,14 +51,7 @@ class DexieDBManager extends BaseStorageManager {
         this._ensureDbConnection();
 
         this.db.todos
-            .get(itemNumber)
-            .then((todoItem) => {
-                if (!todoItem)
-                    throw new Error(`Todo item with itemNumber '${itemNumber}' not found`);
-
-                todoItem.completed = completed;
-                return this.db.todos.put(todoItem);
-            })
+            .update(itemNumber, {completed: completed})
             .then(() => {
                 this._handleToggleComplete();
             })

experimental/javascript-wc-indexeddb/src/storage/indexedDB-manager.js

@@ -89,9 +89,10 @@ class IndexedDBManager extends BaseStorageManager {
                     itemsProcessed++;
                     cursor.continue(); // Move to next item
                 } else {
-                    // We're done - sort items by itemNumber in descending order
-                    // for proper display order (newest to oldest)
+                    // We're done - sort items by itemNumber in ascending order
+                    // for proper display order (oldest to newest)
                     items.sort((a, b) => a.itemNumber - b.itemNumber);
+                    transaction.commit();
                     resolve(items);
                 }
             };