Skip to content

Commit 9275b1c

Browse files
committed
fix problems on db configuration/reset
1 parent 5e04775 commit 9275b1c

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

jdk_8_maven/em/embedded/rest/catwatch/src/main/java/em/embedded/org/zalando/EmbeddedEvoMasterController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ public String startSut() {
8181
dbSpecification = Arrays.asList(new DbSpecification(){{
8282
dbType = DatabaseType.H2;
8383
connection = sqlConnection;
84-
schemaNames = Arrays.asList("schema_version");
8584
}});
8685

8786
return "http://localhost:" + getSutPort();

jdk_8_maven/em/embedded/rest/proxyprint/src/main/java/em/embedded/io/github/proxyprint/kitchen/EmbeddedEvoMasterController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ public String startSut() {
8585
dbSpecification = Arrays.asList(new DbSpecification(){{
8686
dbType = DatabaseType.H2;
8787
connection = sqlConnection;
88+
employSmartDbClean = false;
8889
}});
8990

9091
return "http://localhost:" + getSutPort();
@@ -114,7 +115,7 @@ public String getPackagePrefixesToCover() {
114115

115116
@Override
116117
public void resetStateOfSUT() {
117-
// DbCleaner.clearDatabase_H2(connection);
118+
DbCleaner.clearDatabase_H2(sqlConnection);
118119

119120
deleteDir(new File("./target/temp"));
120121

jdk_8_maven/em/embedded/rest/scout-api/src/main/java/em/embedded/se/devscout/scoutapi/EmbeddedEvoMasterController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public static void main(String[] args) {
4343

4444
private ScoutAPIApplication application;
4545
private Connection sqlConnection;
46-
private List<String> sqlCommands;
46+
private final List<String> sqlCommands;
4747
private List<DbSpecification> dbSpecification;
4848

4949
public EmbeddedEvoMasterController() {
@@ -90,8 +90,8 @@ public String startSut() {
9090

9191
dbSpecification = Arrays.asList(new DbSpecification(){{
9292
dbType = DatabaseType.H2;
93-
initSqlOnResourcePath = String.join("\n", sqlCommands);
9493
connection = sqlConnection;
94+
employSmartDbClean = false;
9595
}});
9696

9797
resetStateOfSUT();
@@ -137,8 +137,8 @@ public void resetStateOfSUT() {
137137

138138
deleteDir(new File("./target/temp"));
139139

140-
// DbCleaner.clearDatabase_H2(connection);
141-
// SqlScriptRunner.runCommands(connection, sqlCommands);
140+
DbCleaner.clearDatabase_H2(sqlConnection);
141+
SqlScriptRunner.runCommands(sqlConnection, sqlCommands);
142142
}
143143

144144

jdk_8_maven/em/external/rest/catwatch/src/main/java/em/external/org/zalando/ExternalEvoMasterController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ public void postStart() {
150150
dbSpecification = Arrays.asList(new DbSpecification(){{
151151
dbType = DatabaseType.H2;
152152
connection = sqlConnection;
153-
schemaNames = Arrays.asList("schema_version");
154153
}});
155154
} catch (Exception e) {
156155
throw new RuntimeException(e);

jdk_8_maven/em/external/rest/proxyprint/src/main/java/em/external/io/github/proxyprint/kitchen/ExternalEvoMasterController.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ public void postStart() {
158158
dbSpecification = Arrays.asList(new DbSpecification(){{
159159
dbType = DatabaseType.H2;
160160
connection = sqlConnection;
161+
employSmartDbClean = false;
161162
}});
162163
} catch (Exception e) {
163164
throw new RuntimeException(e);
@@ -166,7 +167,7 @@ public void postStart() {
166167

167168
@Override
168169
public void resetStateOfSUT() {
169-
// DbCleaner.clearDatabase_H2(connection);
170+
DbCleaner.clearDatabase_H2(sqlConnection);
170171

171172
deleteDir(new File("./target/temp"));
172173

jdk_8_maven/em/external/rest/scout-api/src/main/java/em/external/se/devscout/scoutapi/ExternalEvoMasterController.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public static void main(String[] args) {
7575

7676
private Connection sqlConnection;
7777
private List<DbSpecification> dbSpecification;
78-
private List<String> sqlCommands;
78+
private final List<String> sqlCommands;
7979
private Server h2;
8080

8181

@@ -198,8 +198,8 @@ public void postStart() {
198198
sqlConnection = DriverManager.getConnection(dbUrl(), "sa", "");
199199
dbSpecification = Arrays.asList(new DbSpecification(){{
200200
dbType = DatabaseType.H2;
201-
initSqlOnResourcePath = String.join("\n", sqlCommands);
202201
connection = sqlConnection;
202+
employSmartDbClean = false;
203203
}});
204204
} catch (Exception e) {
205205
throw new RuntimeException(e);
@@ -230,8 +230,8 @@ public void resetStateOfSUT() {
230230

231231
deleteDir(new File(tmpDir));
232232

233-
// DbCleaner.clearDatabase_H2(connection);
234-
// SqlScriptRunner.runCommands(connection, sqlCommands);
233+
DbCleaner.clearDatabase_H2(sqlConnection);
234+
SqlScriptRunner.runCommands(sqlConnection, sqlCommands);
235235
}
236236

237237
private void deleteDir(File file) {

0 commit comments

Comments
 (0)