Skip to content

Commit d5ba0b6

Browse files
authored
[NFC] Fuzzer: Rename the misleading void-returning get() method (#8022)
1 parent 13fe0e3 commit d5ba0b6

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/tools/execution-results.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -311,9 +311,9 @@ struct ExecutionResults {
311311
// If set, we should ignore this and not compare it to anything.
312312
bool ignore = false;
313313

314-
// Get results of executing a module. Optionally, provide a second module to
315-
// link with it (like fuzz_shell's second module).
316-
void get(Module& wasm, Module* second = nullptr) {
314+
// Execute a module and collect the results. Optionally, provide a second
315+
// module to link with it (like fuzz_shell's second module).
316+
void collect(Module& wasm, Module* second = nullptr) {
317317
try {
318318
// Instantiate the first module.
319319
LoggingExternalInterface interface(loggings, wasm);
@@ -427,7 +427,7 @@ struct ExecutionResults {
427427
// get current results and check them against previous ones
428428
void check(Module& wasm) {
429429
ExecutionResults optimizedResults;
430-
optimizedResults.get(wasm);
430+
optimizedResults.collect(wasm);
431431
if (optimizedResults != *this) {
432432
std::cout << "[fuzz-exec] optimization passes changed results\n";
433433
exit(1);

src/tools/wasm-opt.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,14 +367,14 @@ For more on how to optimize effectively, see
367367
ExecutionResults results;
368368
if (fuzzExecBefore) {
369369
if (fuzzExecSecond.empty()) {
370-
results.get(wasm);
370+
results.collect(wasm);
371371
} else {
372372
// Add the second module.
373373
Module second;
374374
second.features = wasm.features;
375375
ModuleReader().read(fuzzExecSecond, second);
376376

377-
results.get(wasm, &second);
377+
results.collect(wasm, &second);
378378
}
379379
}
380380

0 commit comments

Comments
 (0)