Do not copy function annotations when copying expressions (#8512)

When copying expressions from one function to another, we previously
also copied the function-level annotations from the source function to
the destination. This is not correct, and caused a bug where the
@binaryen.removable.if.unused annotation was copied from an inlined
function to its caller, resulting in side effects being dropped. Fix the
problem by moving responsibility for copying function annotations from
`copyBetweenFunctions` to `copyFunctionWithoutAdd`.

Fixes #8509.

Author: tlively

src/ir/metadata.cpp

@@ -44,8 +44,7 @@ void copyBetweenFunctions(Expression* origin,
                           Function* originFunc,
                           Function* copyFunc) {
   if (originFunc->debugLocations.empty() &&
-      originFunc->codeAnnotations.empty() &&
-      originFunc->funcAnnotations.empty()) {
+      originFunc->codeAnnotations.empty()) {
     // Nothing to copy.
     return;
   }
@@ -75,9 +74,6 @@ void copyBetweenFunctions(Expression* origin,
       }
     }
   }
-
-  // Also copy function-level annotations.
-  copyFunc->funcAnnotations = originFunc->funcAnnotations;
 }
 
 #pragma GCC diagnostic push

src/ir/module-utils.cpp

@@ -73,6 +73,7 @@ copyFunctionWithoutAdd(Function* func,
   ret->localIndices = func->localIndices;
   ret->body = ExpressionManipulator::copy(func->body, out);
   metadata::copyBetweenFunctions(func->body, ret->body, func, ret.get());
+  ret->funcAnnotations = func->funcAnnotations;
   ret->prologLocation = func->prologLocation;
   ret->epilogLocation = func->epilogLocation;
   // Update file indices if needed

test/lit/passes/inlining-optimizing-removable-if-unused.wast

@@ -0,0 +1,33 @@
+;; NOTE: Assertions have been generated by update_lit_checks.py and should not be edited.
+
+;; RUN: wasm-opt %s --inlining-optimizing -S -o - | filecheck %s
+
+(module
+ ;; CHECK:      (import "" "" (func $import (param i32)))
+ (import "" "" (func $import (param i32)))
+ ;; CHECK:      (export "test" (func $test))
+ (export "test" (func $test))
+ ;; CHECK:      (func $test
+ ;; CHECK-NEXT:  (call $import
+ ;; CHECK-NEXT:   (i32.const 0)
+ ;; CHECK-NEXT:  )
+ ;; CHECK-NEXT: )
+ (func $test
+  (call $main)
+ )
+ (func $main
+  (call $print)
+ )
+ (func $print
+  ;; $print should not inherit the removable.if.unused attribute from the
+  ;; inlined call to $removable. (If it did, then we would incorrectly remove
+  ;; the call to the import.)
+  (call $import
+   (call $removable)
+  )
+ )
+ (@binaryen.removable.if.unused)
+ (func $removable (result i32)
+  (i32.const 0)
+ )
+)