Skip to content

Commit 3c9b6a7

Browse files
authored
Use copyTable and copyTag in ModuleSplitter (NFC) (#8410)
1 parent 21b1d2e commit 3c9b6a7

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

src/ir/module-splitting.cpp

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,26 +1029,17 @@ void ModuleSplitter::shareImportableItems() {
10291029
assert(primary.features.hasMutableGlobals() &&
10301030
"TODO: add wrapper functions for disallowed mutable globals");
10311031
}
1032-
auto secondaryGlobal = std::make_unique<Global>();
1033-
secondaryGlobal->type = global->type;
1034-
secondaryGlobal->mutable_ = global->mutable_;
1035-
secondaryGlobal->init =
1036-
global->init == nullptr
1037-
? nullptr
1038-
: ExpressionManipulator::copy(global->init, secondary);
1032+
auto* secondaryGlobal = ModuleUtils::copyGlobal(global.get(), secondary);
10391033
makeImportExport(
10401034
*global, *secondaryGlobal, "global", ExternalKind::Global);
1041-
secondary.addGlobal(std::move(secondaryGlobal));
10421035
}
10431036

10441037
for (auto& tag : primary.tags) {
10451038
if (!used.tags.count(tag->name)) {
10461039
continue;
10471040
}
1048-
auto secondaryTag = std::make_unique<Tag>();
1049-
secondaryTag->type = tag->type;
1041+
auto* secondaryTag = ModuleUtils::copyTag(tag.get(), secondary);
10501042
makeImportExport(*tag, *secondaryTag, "tag", ExternalKind::Tag);
1051-
secondary.addTag(std::move(secondaryTag));
10521043
}
10531044
}
10541045
}

0 commit comments

Comments
 (0)