Add readBinaryWithFeatures to JS API (#8541)

Author: ospencer

src/js/binaryen.js-post.js

@@ -3313,6 +3313,14 @@ Module['readBinary'] = function(data) {
   return wrapModule(ptr);
 };
 
+Module['readBinaryWithFeatures'] = function(data, features) {
+  const buffer = _malloc(data.length);
+  HEAP8.set(data, buffer);
+  const ptr = handleFatalError(() => Module['_BinaryenModuleReadWithFeatures'](buffer, data.length, features));
+  _free(buffer);
+  return wrapModule(ptr);
+};
+
 // Parses text format to a module
 Module['parseText'] = function(text) {
   const buffer = _malloc(text.length + 1);

test/binaryen.js/kitchen-sink.js

@@ -1020,6 +1020,55 @@ function test_binaries() {
   module.dispose();
 }
 
+function test_binaries_with_features() {
+  var builder = new binaryen.TypeBuilder(1);
+  builder.setStructType(0, [
+    { type: binaryen.i32, packedType: binaryen.notPacked, mutable: true },
+    { type: binaryen.f64, packedType: binaryen.notPacked, mutable: true }
+  ]);
+  var [structHeapType] = builder.buildAndDispose();
+  var structType = binaryen.getTypeFromHeapType(structHeapType, true);
+
+  var features = binaryen.Features.ReferenceTypes | binaryen.Features.GC;
+  module = new binaryen.Module();
+  module.setFeatures(features);
+
+  module.addGlobal("struct-global",
+    structType,
+    true,
+    module.struct.new(
+      [module.i32.const(42), module.f64.const(3.14)],
+      binaryen.getHeapType(structType)
+    )
+  );
+
+  module.addFunction("get-field", binaryen.none, binaryen.i32, [],
+    module.struct.get(
+      0,
+      module.global.get("struct-global", structType),
+      binaryen.i32,
+      false
+    )
+  );
+
+  assert(module.validate());
+  binaryen.setDebugInfo(true);
+  var buffer = module.emitBinary();
+  binaryen.setDebugInfo(false);
+  module.dispose();
+
+  module = binaryen.readBinaryWithFeatures(buffer, features);
+
+  assert(module.validate());
+  console.log("module loaded from binary with features:");
+  console.log(module.emitText());
+  module.dispose();
+
+  module = binaryen.readBinaryWithFeatures(buffer, binaryen.Features.MVP);
+  assert(!module.validate());
+  module.dispose();
+}
+
 function test_interpret() {
   // create a simple module with a start method that prints a number, and interpret it, printing that number.
   module = new binaryen.Module();
@@ -1230,6 +1279,7 @@ test_ids();
 test_core();
 test_relooper();
 test_binaries();
+test_binaries_with_features();
 test_interpret();
 test_nonvalid();
 test_parsing();

test/binaryen.js/kitchen-sink.js.txt

@@ -2751,6 +2751,35 @@ module loaded from binary form:
  )
 )
 
+module loaded from binary with features:
+(module
+ (type $0 (struct (field (mut i32)) (field (mut f64))))
+ (type $1 (func (result i32)))
+ (global $struct-global (mut (ref null $0)) (struct.new $0
+  (i32.const 42)
+  (f64.const 3.14)
+ ))
+ (func $get-field (type $1) (result i32)
+  (struct.get $0 0
+   (global.get $struct-global)
+  )
+ )
+)
+
+[wasm-validator error in function get-field] unexpected false: struct.get requires gc [--enable-gc], on 
+(struct.get $struct.0 0
+ (global.get $struct-global)
+)
+[wasm-validator error in module] unexpected false: all used types should be allowed, on 
+struct-global
+[wasm-validator error in module] unexpected false: struct.new requires gc [--enable-gc], on 
+(struct.new $struct.0
+ (i32.const 42)
+ (f64.const 3.14)
+)
+[wasm-validator error in module] unexpected false: , on 
+struct-global
+global type requires additional features [--enable-reference-types --enable-gc]
 (module
  (type $0 (func (param i32)))
  (type $1 (func))