style: simplify null checks

Author: 0xFA11

com.unity.netcode.gameobjects/Editor/NetworkManagerEditor.cs

@@ -231,13 +231,7 @@ public override void OnInspectorGUI()
                     {
                         ReloadTransports();
 
-                        var transportComponent = m_NetworkManager.gameObject.GetComponent(m_TransportTypes[selection - 1]);
-
-                        if (transportComponent == null)
-                        {
-                            transportComponent = m_NetworkManager.gameObject.AddComponent(m_TransportTypes[selection - 1]);
-                        }
-
+                        var transportComponent = m_NetworkManager.gameObject.GetComponent(m_TransportTypes[selection - 1]) ?? m_NetworkManager.gameObject.AddComponent(m_TransportTypes[selection - 1]);
                         m_NetworkTransportProperty.objectReferenceValue = transportComponent;
 
                         Repaint();

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs

@@ -597,13 +597,7 @@ internal void InitializeVariables()
                 var fieldType = sortedFields[i].FieldType;
                 if (fieldType.IsSubclassOf(typeof(NetworkVariableBase)))
                 {
-                    var instance = (NetworkVariableBase)sortedFields[i].GetValue(this);
-
-                    if (instance == null)
-                    {
-                        throw new Exception($"{GetType().FullName}.{sortedFields[i].Name} cannot be null. All {nameof(NetworkVariableBase)} instances must be initialized.");
-                    }
-
+                    var instance = (NetworkVariableBase)sortedFields[i].GetValue(this) ?? throw new Exception($"{GetType().FullName}.{sortedFields[i].Name} cannot be null. All {nameof(NetworkVariableBase)} instances must be initialized.");
                     instance.Initialize(this);
 
                     var instanceNameProperty = fieldType.GetProperty(nameof(NetworkVariableBase.Name));

com.unity.netcode.gameobjects/Runtime/Messaging/DisconnectReasonMessage.cs

@@ -8,11 +8,7 @@ internal struct DisconnectReasonMessage : INetworkMessage
 
         public void Serialize(FastBufferWriter writer, int targetVersion)
         {
-            string reasonSent = Reason;
-            if (reasonSent == null)
-            {
-                reasonSent = string.Empty;
-            }
+            string reasonSent = Reason ?? string.Empty;
 
             // Since we don't send a ConnectionApprovedMessage, the version for this message is encded with the message
             // itself. However, note that we HAVE received a ConnectionRequestMessage, so we DO have a valid targetVersion

com.unity.netcode.gameobjects/Runtime/Serialization/NetworkObjectReference.cs

@@ -54,13 +54,7 @@ public NetworkObjectReference(GameObject gameObject)
                 throw new ArgumentNullException(nameof(gameObject));
             }
 
-            var networkObject = gameObject.GetComponent<NetworkObject>();
-
-            if (networkObject == null)
-            {
-                throw new ArgumentException($"Cannot create {nameof(NetworkObjectReference)} from {nameof(GameObject)} without a {nameof(NetworkObject)} component.");
-            }
-
+            var networkObject = gameObject.GetComponent<NetworkObject>() ?? throw new ArgumentException($"Cannot create {nameof(NetworkObjectReference)} from {nameof(GameObject)} without a {nameof(NetworkObject)} component.");
             if (networkObject.IsSpawned == false)
             {
                 throw new ArgumentException($"{nameof(NetworkObjectReference)} can only be created from spawned {nameof(NetworkObject)}s.");

testproject/Assets/Tests/Runtime/MultiprocessRuntime/TestCoordinator.cs

@@ -453,18 +453,8 @@ public void InvokeFromMethodNameClientRpc(string methodInfoString, byte[] args,
             var split = methodInfoString.Split(k_MethodFullNameSplitChar);
             var (classToExecute, staticMethodToExecute) = (split[0], split[1]);
 
-            var foundType = Type.GetType(classToExecute);
-            if (foundType == null)
-            {
-                throw new Exception($"couldn't find {classToExecute}");
-            }
-
-            var foundMethod = foundType.GetMethod(staticMethodToExecute, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static);
-            if (foundMethod == null)
-            {
-                throw new MissingMethodException($"couldn't find method {staticMethodToExecute}");
-            }
-
+            var foundType = Type.GetType(classToExecute) ?? throw new Exception($"couldn't find {classToExecute}");
+            var foundMethod = foundType.GetMethod(staticMethodToExecute, BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static) ?? throw new MissingMethodException($"couldn't find method {staticMethodToExecute}");
             foundMethod.Invoke(null, args != null ? new object[] { args } : null);
         }
         catch (Exception e)