fix: removing timeouts from integration tests (#3167)

NoelStephensUnity · web-flow · commit a90b0f404096 · 2024-12-11T22:29:41.000-06:00
fix

Removing timesouts from our integration tests:
- TestSendingWithGroupOverride
- TestSendingWithGroupNotOverride
- WhenManyObjectsAreSpawnedAtOnce_AllAreReceived(
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/NetworkObject/NetworkObjectSpawnManyObjectsTests.cs
@@ -47,8 +47,6 @@ protected override void OnServerAndClientsCreated()
         }
 
         [UnityTest]
-        // When this test fails it does so without an exception and will wait the default ~6 minutes
-        [Timeout(10000)]
         public IEnumerator WhenManyObjectsAreSpawnedAtOnce_AllAreReceived()
         {
             for (int x = 0; x < k_SpawnedObjects; x++)
diff --git a/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs b/com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs
@@ -1285,8 +1285,6 @@ public enum AllocationType
             List
         }
 
-        // Extending timeout since the added yield return causes this test to commonly timeout
-        [Timeout(600000)]
         [UnityTest]
         public IEnumerator TestSendingWithGroupOverride()
         {
@@ -1386,8 +1384,6 @@ public enum AllocationType
             List
         }
 
-        // Extending timeout since the added yield return causes this test to commonly timeout
-        [Timeout(600000)]
         [UnityTest]
         public IEnumerator TestSendingWithGroupNotOverride()
         {

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,6 @@ protected override void OnServerAndClientsCreated()`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`[UnityTest]`
`50`		`- // When this test fails it does so without an exception and will wait the default ~6 minutes`
`51`		`- [Timeout(10000)]`
`52`	`50`	`public IEnumerator WhenManyObjectsAreSpawnedAtOnce_AllAreReceived()`
`53`	`51`	`{`
`54`	`52`	`for (int x = 0; x < k_SpawnedObjects; x++)`
Original file line number	Diff line number	Diff line change
`@@ -1285,8 +1285,6 @@ public enum AllocationType`
`1285`	`1285`	`List`
`1286`	`1286`	`}`
`1287`	`1287`
`1288`		`- // Extending timeout since the added yield return causes this test to commonly timeout`
`1289`		`- [Timeout(600000)]`
`1290`	`1288`	`[UnityTest]`
`1291`	`1289`	`public IEnumerator TestSendingWithGroupOverride()`
`1292`	`1290`	`{`
`@@ -1386,8 +1384,6 @@ public enum AllocationType`
`1386`	`1384`	`List`
`1387`	`1385`	`}`
`1388`	`1386`
`1389`		`- // Extending timeout since the added yield return causes this test to commonly timeout`
`1390`		`- [Timeout(600000)]`
`1391`	`1387`	`[UnityTest]`
`1392`	`1388`	`public IEnumerator TestSendingWithGroupNotOverride()`
`1393`	`1389`	`{`