style: order modifiers

Author: 0xFA11

.editorconfig

@@ -28,6 +28,10 @@ dotnet_sort_system_directives_first = true:error
 dotnet_separate_import_directive_groups = false:error
 csharp_using_directive_placement = outside_namespace:error
 
+# Order modifiers
+dotnet_diagnostic.IDE0036.severity = error
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:error
+
 # Avoid "this." if not necessary
 dotnet_style_qualification_for_field = false:error
 dotnet_style_qualification_for_property = false:error

com.unity.netcode.gameobjects/Components/NetworkAnimator.cs

@@ -895,7 +895,7 @@ private void SendParametersUpdate(ClientRpcParams clientRpcParams = default, boo
         /// <summary>
         /// Helper function to get the cached value
         /// </summary>
-        unsafe private T GetValue<T>(ref AnimatorParamCache animatorParamCache)
+        private unsafe T GetValue<T>(ref AnimatorParamCache animatorParamCache)
         {
             T currentValue;
             fixed (void* value = animatorParamCache.Value)
@@ -910,7 +910,7 @@ unsafe private T GetValue<T>(ref AnimatorParamCache animatorParamCache)
         /// If so, it fills out m_ParametersToUpdate with the indices of the parameters
         /// that have changed.  Returns true if any parameters changed.
         /// </summary>
-        unsafe private bool CheckParametersChanged()
+        private unsafe bool CheckParametersChanged()
         {
             m_ParametersToUpdate.Clear();
             for (int i = 0; i < m_CachedAnimatorParameters.Length; i++)

com.unity.netcode.gameobjects/Components/QuaternionCompressor.cs

@@ -51,7 +51,7 @@ public static class QuaternionCompressor
         /// <param name="quaternion">the <see cref="Quaternion"/> to be compressed</param>
         /// <returns>the <see cref="Quaternion"/> compressed as an unsigned integer</returns>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        static public uint CompressQuaternion(ref Quaternion quaternion)
+        public static uint CompressQuaternion(ref Quaternion quaternion)
         {
             // Store off the absolute value for each Quaternion element
             s_QuatAbsValues[0] = Mathf.Abs(quaternion[0]);
@@ -97,7 +97,7 @@ static public uint CompressQuaternion(ref Quaternion quaternion)
         /// <param name="quaternion">quaternion to store the decompressed values within</param>
         /// <param name="compressed">the compressed quaternion</param>
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        static public void DecompressQuaternion(ref Quaternion quaternion, uint compressed)
+        public static void DecompressQuaternion(ref Quaternion quaternion, uint compressed)
         {
             // Get the last two bits for the index to skip (0-3)
             var indexToSkip = (int)(compressed >> 30);

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -1128,13 +1128,13 @@ internal bool NetworkManagerCheckForParent(bool ignoreNetworkManagerCache = fals
             return isParented;
         }
 
-        static internal string GenerateNestedNetworkManagerMessage(Transform transform)
+        internal static string GenerateNestedNetworkManagerMessage(Transform transform)
         {
             return $"{transform.name} is nested under {transform.root.name}. NetworkManager cannot be nested.\n";
         }
 
 #if UNITY_EDITOR
-        static internal INetworkManagerHelper NetworkManagerHelper;
+        internal static INetworkManagerHelper NetworkManagerHelper;
         /// <summary>
         /// Interface for NetworkManagerHelper
         /// </summary>

com.unity.netcode.gameobjects/TestHelpers/Runtime/IntegrationTestSceneHandler.cs

@@ -106,7 +106,7 @@ internal static void VerboseDebug(string message)
         /// Processes scene loading jobs
         /// </summary>
         /// <param name="queuedSceneJob">job to process</param>
-        static internal IEnumerator ProcessLoadingSceneJob(QueuedSceneJob queuedSceneJob)
+        internal static IEnumerator ProcessLoadingSceneJob(QueuedSceneJob queuedSceneJob)
         {
             var itegrationTestSceneHandler = queuedSceneJob.IntegrationTestSceneHandler;
             while (!itegrationTestSceneHandler.OnCanClientsLoad())
@@ -180,7 +180,7 @@ private static void ProcessInSceneObjects(Scene scene, NetworkManager networkMan
         /// Processes scene unloading jobs
         /// </summary>
         /// <param name="queuedSceneJob">job to process</param>
-        static internal IEnumerator ProcessUnloadingSceneJob(QueuedSceneJob queuedSceneJob)
+        internal static IEnumerator ProcessUnloadingSceneJob(QueuedSceneJob queuedSceneJob)
         {
             var itegrationTestSceneHandler = queuedSceneJob.IntegrationTestSceneHandler;
             while (!itegrationTestSceneHandler.OnCanClientsUnload())
@@ -223,7 +223,7 @@ private static void SceneManager_sceneUnloaded(Scene scene)
         /// Processes all jobs within the queue.
         /// When all jobs are finished, the coroutine stops.
         /// </summary>
-        static internal IEnumerator JobQueueProcessor()
+        internal static IEnumerator JobQueueProcessor()
         {
             while (QueuedSceneJobs.Count != 0)
             {

com.unity.netcode.gameobjects/Tests/Runtime/NetworkShowHideTests.cs

@@ -71,7 +71,7 @@ public override void OnNetworkDespawn()
         public NetworkList<int> MyListSetOnSpawn;
         public NetworkVariable<int> MyOwnerReadNetworkVariable;
         public NetworkList<int> MyList;
-        static public NetworkManager NetworkManagerOfInterest;
+        public static NetworkManager NetworkManagerOfInterest;
 
         internal static int GainOwnershipCount = 0;
 

com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformTests.cs

@@ -63,9 +63,9 @@ public void CommitToTransform()
     /// </summary>
     public class ChildObjectComponent : NetworkBehaviour
     {
-        public readonly static List<ChildObjectComponent> Instances = new List<ChildObjectComponent>();
+        public static readonly List<ChildObjectComponent> Instances = new List<ChildObjectComponent>();
         public static ChildObjectComponent ServerInstance { get; internal set; }
-        public readonly static Dictionary<ulong, NetworkObject> ClientInstances = new Dictionary<ulong, NetworkObject>();
+        public static readonly Dictionary<ulong, NetworkObject> ClientInstances = new Dictionary<ulong, NetworkObject>();
 
         public static void Reset()
         {

com.unity.netcode.gameobjects/Tests/Runtime/OwnerModifiedTests.cs

@@ -16,7 +16,7 @@ public class OwnerModifiedObject : NetworkBehaviour, INetworkUpdateSystem
     {
         public NetworkList<int> MyNetworkList;
 
-        static internal int Updates = 0;
+        internal static int Updates = 0;
 
         private void Awake()
         {

testproject/Assets/Scripts/AddressablesBuilder.cs

@@ -6,7 +6,7 @@
 
 public class AddressablesBuilder
 {
-    static public void PreExport()
+    public static void PreExport()
     {
         if (AddressableAssetSettingsDefaultObject.Settings != null)
         {

testproject/Assets/Tests/Manual/InSceneObjectParentingTests/InSceneParentedUnderGameObjectHandler.cs

@@ -5,7 +5,7 @@ namespace TestProject.ManualTests
 {
     public class InSceneParentedUnderGameObjectHandler : NetworkBehaviour
     {
-        static public List<InSceneParentedUnderGameObjectHandler> Instances = new List<InSceneParentedUnderGameObjectHandler>();
+        public static List<InSceneParentedUnderGameObjectHandler> Instances = new List<InSceneParentedUnderGameObjectHandler>();
 
         public override void OnNetworkSpawn()
         {