fix: Removing objects that got deleted from list of Dirty NetworkObjects (#2185)

jeffreyrainy · web-flow · commit 22df9e88e277 · 2022-09-09T14:20:06.000-04:00
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs
@@ -26,6 +26,10 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
 #endif
             try
             {
+                // NetworkObject references can become null, when hidden or despawned. Once NUll, there is no point
+                // trying to process them, even if they were previously marked as dirty.
+                m_DirtyNetworkObjects.RemoveWhere((sobj) => sobj == null);
+
                 if (networkManager.IsServer)
                 {
                     foreach (var dirtyObj in m_DirtyNetworkObjects)

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,10 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)`
`26`	`26`	`#endif`
`27`	`27`	`try`
`28`	`28`	`{`
	`29`	`+ // NetworkObject references can become null, when hidden or despawned. Once NUll, there is no point`
	`30`	`+ // trying to process them, even if they were previously marked as dirty.`
	`31`	`+ m_DirtyNetworkObjects.RemoveWhere((sobj) => sobj == null);`
	`32`	`+`
`29`	`33`	`if (networkManager.IsServer)`
`30`	`34`	`{`
`31`	`35`	`foreach (var dirtyObj in m_DirtyNetworkObjects)`