update - child network behaviours

This update is the first pass to making ChildNetworkBehaviours a table keyed off of the NetworkBehahviour identifiers.
This allows for the removal of a NetworkBehaviour without it impacting the remaining NetworkBehaviours.
This could most likely be optimized by generating the initial table ahead of time on each prefab.
In-scene placed that are not registered prefabs would need to do this upon being instantiated.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs

@@ -56,9 +56,9 @@ internal void ProcessDirtyObjectServer(NetworkObject dirtyObj, bool forceSend)
                 if (m_NetworkManager.DistributedAuthorityMode || dirtyObj.IsNetworkVisibleTo(client.ClientId))
                 {
                     // Sync just the variables for just the objects this client sees
-                    for (int k = 0; k < dirtyObj.ChildNetworkBehaviours.Count; k++)
+                    foreach(var childBehaviour in dirtyObj.ChildNetworkBehaviours)
                     {
-                        dirtyObj.ChildNetworkBehaviours[k].NetworkVariableUpdate(client.ClientId, forceSend);
+                        childBehaviour.Value.NetworkVariableUpdate(client.ClientId, forceSend);
                     }
                 }
             }
@@ -73,9 +73,9 @@ internal void ProcessDirtyObjectServer(NetworkObject dirtyObj, bool forceSend)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         internal void ProcessDirtyObjectClient(NetworkObject dirtyObj, bool forceSend)
         {
-            for (int k = 0; k < dirtyObj.ChildNetworkBehaviours.Count; k++)
+            foreach (var childBehaviour in dirtyObj.ChildNetworkBehaviours)
             {
-                dirtyObj.ChildNetworkBehaviours[k].NetworkVariableUpdate(NetworkManager.ServerClientId, forceSend);
+                childBehaviour.Value.NetworkVariableUpdate(NetworkManager.ServerClientId, forceSend);
             }
         }
 
@@ -86,9 +86,9 @@ internal void ProcessDirtyObjectClient(NetworkObject dirtyObj, bool forceSend)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         internal void PostProcessDirtyObject(NetworkObject dirtyObj)
         {
-            for (int k = 0; k < dirtyObj.ChildNetworkBehaviours.Count; k++)
+            foreach (var behaviourEntry in dirtyObj.ChildNetworkBehaviours)
             {
-                var behaviour = dirtyObj.ChildNetworkBehaviours[k];
+                var behaviour = behaviourEntry.Value;
                 for (int i = 0; i < behaviour.NetworkVariableFields.Count; i++)
                 {
                     // Set to true for NetworkVariable to ignore duplication of the
@@ -116,7 +116,7 @@ internal void ResetDirtyObject(NetworkObject dirtyObj, bool forceSend)
         {
             foreach (var behaviour in dirtyObj.ChildNetworkBehaviours)
             {
-                behaviour.PostNetworkVariableWrite(forceSend);
+                behaviour.Value.PostNetworkVariableWrite(forceSend);
             }
         }
 
@@ -164,9 +164,9 @@ internal void ProcessDirtyObject(NetworkObject networkObject, bool forceSend)
             }
 
             // Pre-variable update
-            for (int k = 0; k < networkObject.ChildNetworkBehaviours.Count; k++)
+            foreach (var childBehaviour in networkObject.ChildNetworkBehaviours)
             {
-                networkObject.ChildNetworkBehaviours[k].PreVariableUpdate();
+                childBehaviour.Value.PreVariableUpdate();
             }
 
             // Server sends updates to all clients where a client sends updates