fix: Letting NetworkVariables be serialized even if they're not going to be sent (#2263)

jeffreyrainy · web-flow · commit 01d7ed7d3dec · 2022-10-17T11:14:27.000-04:00
fix: Letting NetworkVariables be serialized even if they're not going to be sent. This prevents NetworkList synchronization issues
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs
@@ -42,10 +42,6 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
                         for (int i = 0; i < networkManager.ConnectedClientsList.Count; i++)
                         {
                             var client = networkManager.ConnectedClientsList[i];
-                            if (networkManager.IsHost && client.ClientId == networkManager.LocalClientId)
-                            {
-                                continue;
-                            }
 
                             if (dirtyObj.IsNetworkVisibleTo(client.ClientId))
                             {

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,6 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)`
`42`	`42`	`for (int i = 0; i < networkManager.ConnectedClientsList.Count; i++)`
`43`	`43`	`{`
`44`	`44`	`var client = networkManager.ConnectedClientsList[i];`
`45`		`- if (networkManager.IsHost && client.ClientId == networkManager.LocalClientId)`
`46`		`- {`
`47`		`- continue;`
`48`		`- }`
`49`	`45`
`50`	`46`	`if (dirtyObj.IsNetworkVisibleTo(client.ClientId))`
`51`	`47`	`{`