[SRPF][Graphics Tools] Render Pipeline Converter - Search Request was wrongly handled and disposed before it was completed.

As the Search request is executed asyncronously. if we dispose the context. The RP converter for Buit in materials can not finish properly.

Disposing the context, when is finished.

Author: alex-vazquez-unity3d

Packages/com.unity.render-pipelines.universal/Editor/Converter/ReadonlyMaterialConverter.cs

@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Text;
 using UnityEditor.SceneManagement;
+using UnityEditor.Search;
 using UnityEngine;
 using UnityEngine.SceneManagement;
 using Object = UnityEngine.Object;
@@ -46,40 +47,43 @@ internal class ReadonlyMaterialConverter : RenderPipelineConverter
 
         public override void OnInitialize(InitializeConverterContext ctx, Action callback)
         {
-            var context = Search.SearchService.CreateContext("asset", "urp=convert-readonly a=URPConverterIndex");
-
-            Search.SearchService.Request(context, (c, items) =>
-            {
-                // we're going to do this step twice in order to get them ordered, but it should be fast
-                var orderedRequest = items.OrderBy(req =>
+            Search.SearchService.Request
+            (
+                Search.SearchService.CreateContext("asset", "urp=convert-readonly a=URPConverterIndex"),
+                (searchContext, items) =>
                 {
-                    GlobalObjectId.TryParse(req.id, out var gid);
-                    return gid.assetGUID;
-                });
+                    // we're going to do this step twice in order to get them ordered, but it should be fast
+                    var orderedRequest = items.OrderBy(req =>
+                    {
+                        GlobalObjectId.TryParse(req.id, out var gid);
+                        return gid.assetGUID;
+                    });
 
-                foreach (var r in orderedRequest)
-                {
-                    if (r == null || !GlobalObjectId.TryParse(r.id, out var gid))
+                    foreach (var r in orderedRequest)
                     {
-                        continue;
-                    }
+                        if (string.IsNullOrEmpty(r?.id) ||
+                            !GlobalObjectId.TryParse(r.id, out var gid))
+                        {
+                            continue;
+                        }
 
-                    var label = r.provider.fetchLabel(r, r.context);
-                    var description = r.provider.fetchDescription(r, r.context);
+                        var label = r.provider.fetchLabel(r, r.context);
+                        var description = r.provider.fetchDescription(r, r.context);
 
-                    var item = new ConverterItemDescriptor()
-                    {
-                        name = description.Split('/').Last().Split('.').First(),
-                        info = $"{label}",
-                    };
-                    guids.Add(gid.ToString());
+                        var item = new ConverterItemDescriptor()
+                        {
+                            name = description.Split('/').Last().Split('.').First(),
+                            info = $"{label}",
+                        };
+                        guids.Add(gid.ToString());
 
-                    ctx.AddAssetToConvert(item);
-                }
+                        ctx.AddAssetToConvert(item);
+                    }
 
-                callback.Invoke();
-            });
-            context?.Dispose();
+                    callback.Invoke();
+                    searchContext?.Dispose();
+                }
+            );
         }
 
         public override void OnRun(ref RunItemContext ctx)

Packages/com.unity.render-pipelines.universal/Editor/Converter/RenderPipelineConvertersEditor.cs

@@ -355,6 +355,15 @@ void HideConverterLayout(VisualElement element)
         }
         void ToggleAllNone(ClickEvent evt, int index, bool value, VisualElement item)
         {
+            void ToggleSelection(Label labelSelected, Label labelNotSelected)
+            {
+                labelSelected.AddToClassList("selected");
+                labelSelected.RemoveFromClassList("not_selected");
+
+                labelNotSelected.AddToClassList("not_selected");
+                labelNotSelected.RemoveFromClassList("selected");
+            }
+
             var conv = m_ConverterStates[index];
             if (conv.items.Count > 0)
             {
@@ -363,22 +372,18 @@ void ToggleAllNone(ClickEvent evt, int index, bool value, VisualElement item)
                     convItem.isActive = value;
                 }
                 UpdateSelectedConverterItems(index, item);
+
+                var allLabel = item.Q<Label>("all");
+                var noneLabel = item.Q<Label>("none");
+
                 // Changing the look of the labels
                 if (value)
                 {
-                    item.Q<Label>("all").AddToClassList("selected");
-                    item.Q<Label>("all").RemoveFromClassList("not_selected");
-
-                    item.Q<Label>("none").AddToClassList("not_selected");
-                    item.Q<Label>("none").RemoveFromClassList("selected");
+                    ToggleSelection(allLabel, noneLabel);
                 }
                 else
                 {
-                    item.Q<Label>("none").AddToClassList("selected");
-                    item.Q<Label>("none").RemoveFromClassList("not_selected");
-
-                    item.Q<Label>("all").AddToClassList("not_selected");
-                    item.Q<Label>("all").RemoveFromClassList("selected");
+                    ToggleSelection(noneLabel, allLabel);
                 }
             }
         }