[HDRP] Refactor clouds and water out of HDRenderPipeline

Moved water and clouds as separate systems instead of being part of HDRenderPipeline class. This helps modularizing the code and simplifies dependencies.
Additionally, moved each resources to per system classes that can be stripped independently of the rest of the pipeline resources if the feature is not used at build time. As a result, they show in their own section in the global settings:
![image](https://media.github.cds.internal.unity3d.com/user/2154/files/85471fac-567a-427d-8e56-66feb54b7b57)

Author: adrien-de-tocqueville

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.RenderingLayers.cs

@@ -58,7 +58,7 @@ class DefaultRenderingLayer : RenderingLayerBaker
             NativeArray<uint> layerMask;
 
             public override NativeArray<uint> renderingLayerMasks => layerMask;
-            
+
             CommandBuffer cmd;
             IRayTracingAccelStruct m_AccelerationStructure;
             GraphicsBuffer scratchBuffer;
@@ -141,7 +141,7 @@ public override bool Step()
             {
                 if (currentStep >= stepCount)
                     return true;
-                
+
                 var shader = s_TracingContext.shaderRL;
 
                 int batchOffset = batchIndex * k_MaxProbeCountPerBatch;
@@ -152,7 +152,7 @@ public override bool Step()
                 shader.SetVectorParam(cmd, _RenderingLayerMasks, regionMasks);
                 shader.SetBufferParam(cmd, _ProbePositions, probePositionsBuffer);
                 shader.SetBufferParam(cmd, _LayerMasks, layerMaskBuffer);
-                
+
                 shader.Dispatch(cmd, scratchBuffer, (uint)batchSize, 1, 1);
                 batchIndex++;
 

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.SkyOcclusion.cs

@@ -40,10 +40,10 @@ public abstract class SkyOcclusionBaker : IDisposable
             /// Performs necessary tasks to free allocated resources.
             /// </summary>
             public abstract void Dispose();
-            
+
             internal NativeArray<uint> encodedDirections;
             internal void Encode() { encodedDirections = EncodeShadingDirection(shadingDirections); }
-            
+
             static int k_MaxProbeCountPerBatch = 65535;
             static readonly int _SkyShadingPrecomputedDirection = Shader.PropertyToID("_SkyShadingPrecomputedDirection");
             static readonly int _SkyShadingDirections = Shader.PropertyToID("_SkyShadingDirections");
@@ -71,7 +71,7 @@ internal static NativeArray<uint> EncodeShadingDirection(NativeArray<Vector3> di
                 {
                     int batchOffset = batchIndex * k_MaxProbeCountPerBatch;
                     int probeInBatch = Mathf.Min(probeCount - batchOffset, k_MaxProbeCountPerBatch);
-                    
+
                     directionBuffer.SetData(directions, batchOffset, 0, probeInBatch);
 
                     cs.SetBuffer(kernel, _SkyShadingPrecomputedDirection, precomputedShadingDirections);
@@ -84,7 +84,7 @@ internal static NativeArray<uint> EncodeShadingDirection(NativeArray<Vector3> di
                     var batchResult = directionResults.GetSubArray(batchOffset, probeInBatch);
                     AsyncGPUReadback.RequestIntoNativeArray(ref batchResult, encodedBuffer, probeInBatch * sizeof(uint), 0).WaitForCompletion();
                 }
-                
+
                 directionBuffer.Dispose();
                 encodedBuffer.Dispose();
 

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeGIBaking.cs

@@ -869,7 +869,7 @@ static TouchupVolumeWithBoundsList GetAdjustementVolumes()
                     touchup.skyDirection.Normalize();
                 }
             }
-            
+
             // Sort by volume to give priority to bigger volumes so smaller volumes are applied last
             touchupVolumesAndBounds.Sort((a, b) => (b.volume.ComputeVolume(b.obb).CompareTo(a.volume.ComputeVolume(a.obb))));
 
@@ -1169,7 +1169,7 @@ class CacheEntry
             CacheEntry BuildMap(in BakingCell cell)
             {
                 var entry = m_BrickMetaPool.Get();
-                
+
                 // Build a map from voxel to brick
                 // A voxel is the size of a brick at subdivision level 0
                 foreach (var brick in cell.bricks)
@@ -1192,7 +1192,7 @@ CacheEntry BuildMap(in BakingCell cell)
 
                 return entry;
             }
-            
+
             public Dictionary<int, Brick> GetMap(in BakingCell cell)
             {
                 if (!cache.TryGetValue(cell.index, out var entry))
@@ -1242,7 +1242,7 @@ static void FixSeams(NativeArray<int> positionRemap, NativeArray<Vector3> positi
                 float scale = m_ProfileInfo.minBrickSize / ProbeBrickPool.kBrickCellCount;
                 float minBrickSize = m_ProfileInfo.minBrickSize;
                 Brick largestBrick = default;
-                
+
                 int numProbes = cell.probePositions.Length;
                 for (int probeIndex = 0; probeIndex < numProbes; ++probeIndex)
                 {

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbePlacement.cs

@@ -239,7 +239,7 @@ public static Brick[] SubdivideCell(Vector3Int cellPosition, Bounds cellBounds,
                         SubdivideSubCell(subVolume.bounds, subdivisionCtx, ctx, filteredContributors, overlappingProbeVolumes, subBrickSet);
                         if (subBrickSet.Count == 0)
                             continue;
-                        
+
                         // Make sure no bricks with unwanted subdiv level are generated
                         if (requireSubFiltering && !fastSubFiltering)
                         {

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeBakingSetEditor.cs

@@ -268,7 +268,7 @@ void ProbeInvaliditySettingsGUI()
 
             EditorGUILayout.Space();
         }
-        
+
         bool RenameEvent(Rect rect, bool active, bool focused, int index, ref int renameIndex)
         {
             if (active)
@@ -398,7 +398,7 @@ void RenderingLayersSettingsGUI()
                         else if (!supportsLayers && renderPipelineAssetType != null && renderPipelineAssetType.Name == "UniversalRenderPipelineAsset")
                         {
                             string message = "The current URP Asset does not support Light Layers.";
-                    
+
                             CoreEditorUtils.DrawFixMeBox(message, MessageType.Warning, "Open", () =>
                             {
                                 EditorUtility.OpenPropertyEditor(currentPipeline);

Packages/com.unity.render-pipelines.core/Editor/Lighting/ProbeVolume/ProbeVolumeResourceStripper.cs

@@ -41,16 +41,10 @@ public static bool ProbeVolumeSupportedForBuild()
         {
             bool supportProbeVolume = false;
 
-            using (ListPool<RenderPipelineAsset>.Get(out List<RenderPipelineAsset> rpAssets))
+            foreach (var asset in CoreBuildData.instance.renderPipelineAssets)
             {
-                if (UnityEditor.EditorUserBuildSettings.activeBuildTarget.TryGetRenderPipelineAssets<RenderPipelineAsset>(rpAssets))
-                {
-                    foreach (var asset in rpAssets)
-                    {
-                        if (asset is IProbeVolumeEnabledRenderPipeline probeVolumeEnabledAsset)
-                            supportProbeVolume |= probeVolumeEnabledAsset.supportProbeVolume;
-                    }
-                }
+                if (asset is IProbeVolumeEnabledRenderPipeline probeVolumeEnabledAsset)
+                    supportProbeVolume |= probeVolumeEnabledAsset.supportProbeVolume;
             }
 
             return supportProbeVolume;

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeAdjustmentVolume.cs

@@ -57,7 +57,7 @@ public enum Mode
             /// <summary>Scale probe intensity.</summary>
             IntensityScale = 99, // make sure this appears last
         };
-        
+
         /// <summary>The mode that adjustment volume will operate in. It determines what probes falling within the volume will do. </summary>
         public enum RenderingLayerMaskOperation
         {

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeBrickIndex.cs

@@ -31,7 +31,7 @@ internal class ProbeBrickIndex
         NativeArray<int> m_PhysicalIndexBufferData;
         ComputeBuffer m_DebugFragmentationBuffer;
         int[] m_DebugFragmentationData;
-        
+
         bool m_NeedUpdateIndexComputeBuffer;
         int m_UpdateMinIndex = int.MaxValue;
         int m_UpdateMaxIndex = int.MinValue;
@@ -379,7 +379,7 @@ void MarkBrickInPhysicalBuffer(in IndirectionEntryUpdateInfo entry, Vector3Int b
                 var entryMinIndex = entry.minValidBrickIndexForCellAtMaxRes / minBrickSize;
                 var entryMaxIndex = entry.maxValidBrickIndexForCellAtMaxResPlusOne / minBrickSize;
                 var sizeOfValid = (entryMaxIndex - entryMinIndex);
-                            
+
                 if (brickSubdivLevel >= entrySubdivLevel)
                 {
                     brickMin = Vector3Int.zero;
@@ -407,14 +407,14 @@ void MarkBrickInPhysicalBuffer(in IndirectionEntryUpdateInfo entry, Vector3Int b
                     brickMin -= entryMinIndex;
                     brickMax -= entryMinIndex;
                 }
-                            
+
                 // Analytically compute min and max because doing it in the inner loop with Math.Min/Max is costly (not inlined)
                 int chunkStart = entry.firstChunkIndex * kIndexChunkSize;
                 int newMin = chunkStart + LocationToIndex(brickMin.x, brickMin.y, brickMin.z, sizeOfValid);
                 int newMax = chunkStart + LocationToIndex(brickMax.x - 1, brickMax.y - 1, brickMax.z - 1, sizeOfValid);
                 m_UpdateMinIndex = Math.Min(m_UpdateMinIndex, newMin);
                 m_UpdateMaxIndex = Math.Max(m_UpdateMaxIndex, newMax);
-                            
+
                 // Loop through all touched voxels
                 for (int x = brickMin.x; x < brickMax.x; ++x)
                 {
@@ -461,7 +461,7 @@ public void AddBricks(CellIndexInfo cellInfo, NativeArray<Brick> bricks, List<Ch
                     int brickSize = ProbeReferenceVolume.CellSize(brick.subdivisionLevel);
                     Vector3Int brickMin = brick.position;
                     Vector3Int brickMax = brick.position + new Vector3Int(brickSize, brickSize, brickSize);
-                    
+
                     // Find all entries that this brick touch (usually only one, but several in case of bigger bricks)
                     foreach (var entry in cellInfo.updateInfo.entriesInfo)
                     {

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeVolumeBakingSet.cs

@@ -148,7 +148,7 @@ struct SerializedPerSceneCellList
         [SerializeField] internal int supportLayerMaskChunkSize;
         [SerializeField] internal int supportOffsetsChunkSize;
         [SerializeField] internal int supportDataChunkSize;
-        
+
         internal bool bakedSkyOcclusion
         {
             get => bakedSkyOcclusionValue <= 0 ? false : true;
@@ -263,7 +263,7 @@ internal bool bakedSkyShadingDirection
         /// Bake sky shading direction.
         /// </summary>
         public bool skyOcclusionShadingDirection = false;
-        
+
         [Serializable]
         internal struct ProbeLayerMask
         {

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeVolumeGlobalSettings.cs

@@ -4,7 +4,7 @@ namespace UnityEngine.Rendering
 {
     [Serializable]
     [SupportedOnRenderPipeline()]
-    [Categorization.CategoryInfo(Name = "R: Probe Volume", Order = 1000), HideInInspector]
+    [Categorization.CategoryInfo(Name = "R: Adaptive Probe Volumes", Order = 1000), HideInInspector]
     class ProbeVolumeRuntimeResources : IRenderPipelineResources
     {
         [SerializeField, HideInInspector]
@@ -23,7 +23,7 @@ class ProbeVolumeRuntimeResources : IRenderPipelineResources
 
     [Serializable]
     [SupportedOnRenderPipeline()]
-    [Categorization.CategoryInfo(Name = "R: Probe Volume", Order = 1000), HideInInspector]
+    [Categorization.CategoryInfo(Name = "R: Adaptive Probe Volumes", Order = 1000), HideInInspector]
     class ProbeVolumeDebugResources : IRenderPipelineResources
     {
         [SerializeField, HideInInspector]
@@ -48,7 +48,7 @@ class ProbeVolumeDebugResources : IRenderPipelineResources
 
     [Serializable]
     [SupportedOnRenderPipeline()]
-    [Categorization.CategoryInfo(Name = "R: Probe Volume", Order = 1000), HideInInspector]
+    [Categorization.CategoryInfo(Name = "R: Adaptive Probe Volumes", Order = 1000), HideInInspector]
     class ProbeVolumeBakingResources : IRenderPipelineResources
     {
         [SerializeField, HideInInspector]
@@ -82,7 +82,7 @@ class ProbeVolumeBakingResources : IRenderPipelineResources
 
     [Serializable]
     [SupportedOnRenderPipeline()]
-    [Categorization.CategoryInfo(Name = "Probe Volume", Order = 20)]
+    [Categorization.CategoryInfo(Name = "Adaptive Probe Volumes", Order = 20)]
     class ProbeVolumeGlobalSettings : IRenderPipelineGraphicsSettings
     {
         [SerializeField, HideInInspector]