Commit 177c2b6
Fix Render Graph Viewer warnings on HDRP due to duplicate pass names
Fix https://jira.unity3d.com/browse/UUM-65820
When capturing data for Render Graph Viewer, we use the RG pass name as key in the dictionary that stores the script file name and line information required for "jump to pass source in IDE" feature. If duplicate pass names are found, a warning is printed to let user know that this mapping will be ambiguous.
In the case of this bug, the helper functions `BeginProfilingSampler` and `EndProfilingSampler` enqueue render passes with a fixed name, leading to multiple duplicate entries and therefore warnings. However, as these passes also call `builder.GenerateDebugData(false)`, they are not visible in RG Viewer in the first place and we can safely ignore them.
Note that the new code added is only ever active during the frame where RG Viewer is opened or the refresh button is clicked, so there is no performance impact.1 parent 8275544 commit 177c2b6
2 files changed
Lines changed: 11 additions & 2 deletions
File tree
- Packages/com.unity.render-pipelines.core/Runtime/RenderGraph
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| 197 | + | |
| 198 | + | |
197 | 199 | | |
198 | 200 | | |
199 | 201 | | |
200 | 202 | | |
201 | 203 | | |
202 | 204 | | |
203 | 205 | | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
204 | 210 | | |
205 | 211 | | |
206 | 212 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1247 | 1247 | | |
1248 | 1248 | | |
1249 | 1249 | | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
1250 | 1253 | | |
1251 | 1254 | | |
1252 | 1255 | | |
| |||
1260 | 1263 | | |
1261 | 1264 | | |
1262 | 1265 | | |
1263 | | - | |
| 1266 | + | |
1264 | 1267 | | |
1265 | 1268 | | |
1266 | 1269 | | |
| |||
1285 | 1288 | | |
1286 | 1289 | | |
1287 | 1290 | | |
1288 | | - | |
| 1291 | + | |
1289 | 1292 | | |
1290 | 1293 | | |
1291 | 1294 | | |
| |||
0 commit comments