New UX design to "enter play mode" settings in Project Settings (23.3 ONLY - DO NOT FORWARD PORT)

juliaperdigueiroUnity · Evergreen · commit 06cb6efcc384 · 2024-04-11T16:13:15.000Z
Applied the changes to the UI to make the "enter play mode" settings clearer and more user friendly. https://jira.unity3d.com/browse/UUM-60957 ![Mar-28-2024 16-36-51](https://media.github.cds.internal.unity3d.com/user/2126/files/befdad22-09df-4bb2-9e47-c1a9f9be9217)
diff --git a/Tests/SRPTests/Projects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXPrefabTests.cs b/Tests/SRPTests/Projects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXPrefabTests.cs
@@ -17,7 +17,6 @@ namespace UnityEditor.VFX.Test
     public class VisualEffectPrefabTest
     {
         List<GameObject> m_gameObjectToDelete = new ();
-        private bool m_OriginalPlayModeOptionEnabled;
         private EnterPlayModeOptions m_OriginalPlayModeOption;
 
         [OneTimeSetUp]
@@ -29,18 +28,15 @@ public void Init()
             camera.transform.localPosition = Vector3.one;
             camera.transform.LookAt(mainCamera.transform);
 
-            m_OriginalPlayModeOptionEnabled = EditorSettings.enterPlayModeOptionsEnabled;
             m_OriginalPlayModeOption = EditorSettings.enterPlayModeOptions;
             EditorSettings.enterPlayModeOptions = EnterPlayModeOptions.DisableDomainReload;
-            EditorSettings.enterPlayModeOptionsEnabled = true;
         }
 
         [OneTimeTearDown]
         public void CleanUp()
         {
             VFXTestCommon.DeleteAllTemporaryGraph();
             EditorSettings.enterPlayModeOptions = m_OriginalPlayModeOption;
-            EditorSettings.enterPlayModeOptionsEnabled = m_OriginalPlayModeOptionEnabled;
 
             foreach (var gameObject in m_gameObjectToDelete)
             {

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ namespace UnityEditor.VFX.Test`
`17`	`17`	`public class VisualEffectPrefabTest`
`18`	`18`	`{`
`19`	`19`	`List<GameObject> m_gameObjectToDelete = new ();`
`20`		`- private bool m_OriginalPlayModeOptionEnabled;`
`21`	`20`	`private EnterPlayModeOptions m_OriginalPlayModeOption;`
`22`	`21`
`23`	`22`	`[OneTimeSetUp]`
`@@ -29,18 +28,15 @@ public void Init()`
`29`	`28`	`camera.transform.localPosition = Vector3.one;`
`30`	`29`	`camera.transform.LookAt(mainCamera.transform);`
`31`	`30`
`32`		`- m_OriginalPlayModeOptionEnabled = EditorSettings.enterPlayModeOptionsEnabled;`
`33`	`31`	`m_OriginalPlayModeOption = EditorSettings.enterPlayModeOptions;`
`34`	`32`	`EditorSettings.enterPlayModeOptions = EnterPlayModeOptions.DisableDomainReload;`
`35`		`- EditorSettings.enterPlayModeOptionsEnabled = true;`
`36`	`33`	`}`
`37`	`34`
`38`	`35`	`[OneTimeTearDown]`
`39`	`36`	`public void CleanUp()`
`40`	`37`	`{`
`41`	`38`	`VFXTestCommon.DeleteAllTemporaryGraph();`
`42`	`39`	`EditorSettings.enterPlayModeOptions = m_OriginalPlayModeOption;`
`43`		`- EditorSettings.enterPlayModeOptionsEnabled = m_OriginalPlayModeOptionEnabled;`
`44`	`40`
`45`	`41`	`foreach (var gameObject in m_gameObjectToDelete)`
`46`	`42`	`{`