Skip to content

Commit 3fb9b5c

Browse files
fix(ui5-textarea): set textarea wrapper padding in base theme file (#13345)
1 parent f35ce97 commit 3fb9b5c

4 files changed

Lines changed: 20 additions & 3 deletions

File tree

packages/main/src/themes/base/TextArea-parameters.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
--_ui5_textarea_value_state_focus_offset: 1px;
2424
--_ui5_textarea_focus_outline_color: var(--sapContent_FocusColor);
2525
--_ui5_textarea_min_height: 2.25rem;
26-
--_ui5_textarea_wrapper_padding: 0;
26+
--_ui5_textarea_wrapper_padding: 0.0625rem;
2727
--_ui5_textarea_success_wrapper_padding: 0;
2828
--_ui5_textarea_warning_error_wrapper_padding: 0;
2929
--_ui5_textarea_information_wrapper_padding: 0;

packages/main/src/themes/sap_horizon/TextArea-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
--_ui5_textarea_readonly_focus_offset: 1px;
1717
--_ui5_textarea_focus_outline_color: var(--sapField_Active_BorderColor);
1818
--_ui5_textarea_value_state_focus_offset: 1px;
19-
--_ui5_textarea_wrapper_padding: 0.0625rem;
2019
--_ui5_textarea_success_wrapper_padding: 0.0625rem;
2120
--_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem;
2221
--_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem;

packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
--_ui5_textarea_readonly_focus_offset: 1px;
1717
--_ui5_textarea_focus_outline_color: var(--sapField_Active_BorderColor);
1818
--_ui5_textarea_value_state_focus_offset: 1px;
19-
--_ui5_textarea_wrapper_padding: 0.0625rem;
2019
--_ui5_textarea_success_wrapper_padding: 0.0625rem;
2120
--_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem;
2221
--_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem;

packages/main/test/pages/TextArea.html

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,25 @@
125125
<ui5-textarea class="fixed-width" placeholder="Growing Text Area" rows="4" growing-max-rows="12" growing></ui5-textarea>
126126
</section>
127127

128+
<section class="group">
129+
<ui5-title>Text Area: Growing with long text</ui5-title>
130+
<ui5-textarea
131+
class="fixed-width"
132+
growing
133+
growing-max-rows="30"
134+
rows="4"
135+
value="some text line 1
136+
some text line 2
137+
some text line 3
138+
some text line 4
139+
some text line 5
140+
some text line 6
141+
some text line 7
142+
some text line 8
143+
some text line 9">
144+
</ui5-textarea>
145+
</section>
146+
128147
<section class="group">
129148
<ui5-title>Text Area: growing with max length 20 characters </ui5-title>
130149
<ui5-textarea id="ta-max-length" class="fixed-width" value-state="Negative" growing maxlength="20" placeholder="Max length"></ui5-textarea>

0 commit comments

Comments
 (0)