Commit fa8d41c
authored
fix(core): backspace mid-text next to columnList moves block BLO-1126 (#2629)
* fix(core): add missing selectionAtBlockStart guard in backspace columnList handler
The "move to end of prev columnList" backspace handler was missing a
check for whether the cursor is at the start of the block. This caused
mid-text backspace next to a columnList to move the entire block into
the column instead of deleting a character.
* fix(core): add missing selectionAtBlockEnd guard in delete columnList handler
Same bug as the backspace handler — the "move first block from next
columnList" delete handler was missing a selectionAtBlockEnd check,
causing mid-text delete next to a columnList to incorrectly move blocks.
Also adds 3 delete tests mirroring the backspace tests, and marks
the mid-text tests with TODOs for vitest browser mode migration.1 parent 5d980c4 commit fa8d41c
File tree
3 files changed
+914
-2
lines changed- packages
- core/src/extensions/tiptap-extensions/KeyboardShortcuts
- xl-multi-column/src/test/commands
- __snapshots__
3 files changed
+914
-2
lines changedLines changed: 16 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
139 | 146 | | |
140 | 147 | | |
141 | 148 | | |
| |||
462 | 469 | | |
463 | 470 | | |
464 | 471 | | |
465 | | - | |
466 | | - | |
| 472 | + | |
| 473 | + | |
467 | 474 | | |
468 | 475 | | |
469 | 476 | | |
470 | 477 | | |
471 | 478 | | |
472 | 479 | | |
473 | 480 | | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
474 | 488 | | |
475 | 489 | | |
476 | 490 | | |
| |||
0 commit comments