fix: Backspace bug when current block is empty and previous block's last child is empty (#2610)

Co-authored-by: Nick the Sick <computers@nickthesick.com>

Author: matthewlipski

package.json

@@ -11,7 +11,7 @@
     "eslint-plugin-import": "^2.32.0",
     "glob": "^10.5.0",
     "nx": "22.5.4",
-    "prettier": "^3.6.2",
+    "prettier": "3.6.2",
     "prettier-plugin-tailwindcss": "^0.6.14",
     "serve": "14.2.4",
     "typescript": "^5.9.3",
@@ -33,7 +33,21 @@
       "msw",
       "nx",
       "unrs-resolver"
-    ]
+    ],
+    "overrides": {
+      "@tiptap/extension-link": "3.15.3",
+      "msw": "2.11.5",
+      "ai": "6.0.5",
+      "@ai-sdk/anthropic": "3.0.2",
+      "@ai-sdk/openai": "3.0.2",
+      "@ai-sdk/groq": "3.0.2",
+      "@ai-sdk/google": "3.0.2",
+      "@ai-sdk/mistral": "3.0.2",
+      "@ai-sdk/openai-compatible": "2.0.2",
+      "@ai-sdk/provider-utils": "4.0.2",
+      "@ai-sdk/react": "3.0.5",
+      "@ai-sdk/gateway": "3.0.4"
+    }
   },
   "packageManager": "pnpm@10.23.0+sha512.21c4e5698002ade97e4efe8b8b4a89a8de3c85a37919f957e7a0f30f38fbc5bbdd05980ffe29179b2fb6e6e691242e098d945d1601772cad0fef5fb6411e2a4b",
   "private": true,

packages/core/src/extensions/tiptap-extensions/KeyboardShortcuts/KeyboardShortcutsExtension.ts

@@ -226,13 +226,26 @@ export const KeyboardShortcutsExtension = Extension.create<{
                 state.doc,
                 blockInfo.bnBlock.beforePos,
               );
-              if (!prevBlockInfo || !prevBlockInfo.isBlockContainer) {
+              if (!prevBlockInfo) {
+                return false;
+              }
+              const bottomNestedPrevBlockInfo = getBottomNestedBlockInfo(
+                state.doc,
+                prevBlockInfo,
+              );
+              if (!bottomNestedPrevBlockInfo.isBlockContainer) {
+                return false;
+              }
+              if (
+                !bottomNestedPrevBlockInfo ||
+                !bottomNestedPrevBlockInfo.isBlockContainer
+              ) {
                 return false;
               }
 
               let chainedCommands = chain();
 
-              // Moves the children of the current block to the previous one.
+              // Moves the children the current block.
               if (blockInfo.childContainer) {
                 chainedCommands.insertContentAt(
                   blockInfo.bnBlock.afterPos,
@@ -241,8 +254,8 @@ export const KeyboardShortcutsExtension = Extension.create<{
               }
 
               if (
-                prevBlockInfo.blockContent.node.type.spec.content ===
-                "tableRow+"
+                bottomNestedPrevBlockInfo.blockContent.node.type.spec
+                  .content === "tableRow+"
               ) {
                 const tableBlockEndPos = blockInfo.bnBlock.beforePos - 1;
                 const tableBlockContentEndPos = tableBlockEndPos - 1;
@@ -254,17 +267,18 @@ export const KeyboardShortcutsExtension = Extension.create<{
                   lastCellParagraphEndPos,
                 );
               } else if (
-                prevBlockInfo.blockContent.node.type.spec.content === ""
+                bottomNestedPrevBlockInfo.blockContent.node.type.spec
+                  .content === ""
               ) {
                 chainedCommands = chainedCommands.setNodeSelection(
-                  prevBlockInfo.blockContent.beforePos,
+                  bottomNestedPrevBlockInfo.blockContent.beforePos,
                 );
               } else {
-                const blockContentStartPos =
-                  prevBlockInfo.blockContent.afterPos - 1;
+                const blockContentEndPos =
+                  bottomNestedPrevBlockInfo.blockContent.afterPos - 1;
 
                 chainedCommands =
-                  chainedCommands.setTextSelection(blockContentStartPos);
+                  chainedCommands.setTextSelection(blockContentEndPos);
               }
 
               return chainedCommands

packages/core/src/schema/blocks/createSpec.ts

@@ -211,15 +211,19 @@ export function addNodeAndExtensionsToSpec<
             editor as any,
           );
 
+          // Cast needed because render returns `dom: HTMLElement | DocumentFragment`
+          // but tiptap's NodeView expects `dom: HTMLElement`
+          const typedNodeView = nodeView as unknown as NodeView;
+
           if (blockImplementation.meta?.selectable === false) {
-            applyNonSelectableBlockFix(nodeView, this.editor);
+            applyNonSelectableBlockFix(typedNodeView, this.editor);
           }
 
           // See explanation for why `update` is not implemented for NodeViews
           // https://github.com/TypeCellOS/BlockNote/pull/1904#discussion_r2313461464
           // TODO: in a future version, we might want to implement updates so that
           // vanilla blocks don't always re-render entirely (https://github.com/TypeCellOS/BlockNote/issues/220)
-          return nodeView;
+          return typedNodeView;
         };
       },
     });

playground/package.json

@@ -27,6 +27,8 @@
     "@blocknote/xl-multi-column": "workspace:^",
     "@blocknote/xl-odt-exporter": "workspace:^",
     "@blocknote/xl-pdf-exporter": "workspace:^",
+    "@emotion/react": "11.14.0",
+    "@emotion/styled": "11.14.1",
     "@liveblocks/core": "3.7.1-tiptap3",
     "@liveblocks/react": "3.7.1-tiptap3",
     "@liveblocks/react-blocknote": "3.7.1-tiptap3",

playground/src/examples.gen.tsx

@@ -321,7 +321,7 @@
           "pathFromRoot": "examples/01-basic",
           "slug": "basic"
         },
-        "readme": "This example makes the editor read-only while showing the same content as the [Default Schema Showcase](/examples/01-basic/04-default-blocks/) example.\n\n**Relevant Docs:**\n\n- [Editor Setup](/docs/getting-started/editor-setup)\n- [Document Structure](/docs/foundations/document-structure)\n- [Default Schema](/docs/foundations/schemas)"
+        "readme": "This example makes the editor read-only while showing the same content as the [Default Schema Showcase](/examples/basic/default-blocks) example.\n\n**Relevant Docs:**\n\n- [Editor Setup](/docs/getting-started/editor-setup)\n- [Document Structure](/docs/foundations/document-structure)\n- [Default Schema](/docs/foundations/schemas)"
       },
       {
         "projectSlug": "testing",