Optimized IOHelperTrait quality by splitting some code

Author: Geolim4

lib/Phpfastcache/Core/Pool/IO/IOHelperTrait.php

@@ -42,6 +42,7 @@ trait IOHelperTrait
      * for files-based drivers
      * @return DriverStatistic
      * @throws PhpfastcacheIOException
+     * @throws PhpfastcacheInvalidArgumentException
      */
     public function getStats(): DriverStatistic
     {
@@ -73,6 +74,7 @@ public function getStats(): DriverStatistic
      * @param bool $skip
      * @return string
      * @throws PhpfastcacheIOException
+     * @throws PhpfastcacheInvalidArgumentException
      */
     protected function getFilePath(string|bool $keyword, bool $skip = false): string
     {
@@ -103,36 +105,12 @@ protected function getFilePath(string|bool $keyword, bool $skip = false): string
      * @return string
      * @throws PhpfastcacheIOException
      * @throws PhpfastcacheInvalidArgumentException
-     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
-     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function getPath(bool $readonly = false): string
     {
-        /**
-         * Get the base system temporary directory
-         */
         $tmpDir = \rtrim(\ini_get('upload_tmp_dir') ?: \sys_get_temp_dir(), '\\/') . DIRECTORY_SEPARATOR . 'phpfastcache';
-
-        /**
-         * Calculate the security key
-         */
-        {
-            $httpHost = $this->getConfig()->getSuperGlobalAccessor()('SERVER', 'HTTP_HOST');
-            $securityKey = $this->getConfig()->getSecurityKey();
-        if (!$securityKey || \mb_strtolower($securityKey) === 'auto') {
-            if (isset($httpHost)) {
-                $securityKey = \preg_replace('/^www./', '', \strtolower(\str_replace(':', '_', $httpHost)));
-            } else {
-                $securityKey = (SapiDetector::isWebScript() ? 'web' : 'cli');
-            }
-        }
-
-        if ($securityKey !== '') {
-            $securityKey .= '/';
-        }
-
-            $securityKey = static::cleanFileName($securityKey);
-        }
+        $httpHost = $this->getConfig()->getSuperGlobalAccessor()('SERVER', 'HTTP_HOST');
+        $securityKey = $this->buildSecurityKey($httpHost);
 
         /**
          * Extends the temporary directory
@@ -149,21 +127,50 @@ public function getPath(bool $readonly = false): string
         $pathSuffix = $securityKey . DIRECTORY_SEPARATOR . $this->getDriverName();
         $fullPath = Directory::getAbsolutePath($path . $pathSuffix);
         $fullPathTmp = Directory::getAbsolutePath($tmpDir . $pathSuffix);
-        $fullPathHash = $this->getConfig()->getDefaultFileNameHashFunction()($fullPath);
+
+        $this->mkdir($fullPath, $fullPathTmp);
 
         /**
          * In readonly mode we only attempt
          * to verify if the directory exists
          * or not, if it does not then we
          * return the temp dir
          */
-        if ($readonly === true) {
+        if ($readonly) {
             if ($this->getConfig()->isAutoTmpFallback() && (!@\file_exists($fullPath) || !@\is_writable($fullPath))) {
                 return $fullPathTmp;
             }
             return $fullPath;
         }
 
+        return realpath($fullPath);
+    }
+
+    protected function buildSecurityKey(?string $httpHost): string
+    {
+        $securityKey = $this->getConfig()->getSecurityKey();
+        if (!$securityKey || \mb_strtolower($securityKey) === 'auto') {
+            if (isset($httpHost)) {
+                $securityKey = \preg_replace('/^www./', '', \strtolower(\str_replace(':', '_', $httpHost)));
+            } else {
+                $securityKey = (SapiDetector::isWebScript() ? 'web' : 'cli');
+            }
+        }
+
+        if (!empty($securityKey)) {
+            $securityKey .= '/';
+        }
+
+        return static::cleanFileName($securityKey);
+    }
+
+    /**
+     * @throws PhpfastcacheIOException
+     */
+    protected function mkdir(string $fullPath, string $fullPathTmp): void
+    {
+        $fullPathHash = $this->getConfig()->getDefaultFileNameHashFunction()($fullPath);
+
         if (!isset($this->tmp[$fullPathHash]) || (!@\file_exists($fullPath) || !@\is_writable($fullPath))) {
             if (!@\file_exists($fullPath)) {
                 if (@mkdir($fullPath, $this->getDefaultChmod(), true) === false && !\is_dir($fullPath)) {
@@ -193,8 +200,6 @@ public function getPath(bool $readonly = false): string
 
             $this->tmp[$fullPathHash] = $fullPath;
         }
-
-        return realpath($fullPath);
     }
 
     /**