Removed "fallback" feature + opcode optis

Author: Geolim4

CHANGELOG.md

@@ -11,4 +11,7 @@
 - Added (required) cookie driver option `awareOfUntrustableData` to enforce developer awareness of non-reliable data storage
 - The "ActOnAll Helper" have been removed in profit of aggregated cluster support
 - Implemented #713 // Reworked "tags" feature by adding 3 strategies: `TAG_STRATEGY_ONE`, `TAG_STRATEGY_ALL`, `TAG_STRATEGY_ONLY`
-- Removed *global static* properties `CacheManager::$ReadHits`, `CacheManager::$WriteHits` replaced by`\Phpfastcache\Entities\DriverIO` callable in`\Phpfastcache\Core\Pool\ExtendedCacheItemPoolInterface::getIO`
+- Removed *global static* properties `CacheManager::$ReadHits`, `CacheManager::$WriteHits` replaced by`\Phpfastcache\Entities\DriverIO` callable in`\Phpfastcache\Core\Pool\ExtendedCacheItemPoolInterface::getIO`
+- Removed deprecated method `ConfigurationOption::getOption()` use `getOptionName()` instead
+- Removed deprecated config option `$ignoreSymfonyNotice`
+- Removed "fallback" feature (use aggregated cluster Master/Slave instead)

lib/Phpfastcache/CacheManager.php

@@ -177,16 +177,12 @@ public static function getInstance(string $driver, ?ConfigurationOptionInterface
             self::$badPracticeOmeter[$driver] = 1;
             $driverClass = self::validateDriverClass(self::getDriverClass($driver));
 
-            try {
-                if (class_exists($driverClass)) {
-                    $configClass = $driverClass::getConfigClass();
-                    self::$instances[$instanceId] = new $driverClass(new $configClass($config->toArray()), $instanceId);
-                    self::$instances[$instanceId]->setEventManager(EventManager::getInstance());
-                } else {
-                    throw new PhpfastcacheDriverNotFoundException(sprintf('The driver "%s" does not exists', $driver));
-                }
-            } catch (PhpfastcacheDriverCheckException $e) {
-                return self::getFallbackInstance($driver, $config, $e);
+            if (class_exists($driverClass)) {
+                $configClass = $driverClass::getConfigClass();
+                self::$instances[$instanceId] = new $driverClass(new $configClass($config->toArray()), $instanceId);
+                self::$instances[$instanceId]->setEventManager(EventManager::getInstance());
+            } else {
+                throw new PhpfastcacheDriverNotFoundException(sprintf('The driver "%s" does not exists', $driver));
             }
         } else {
             if (self::$badPracticeOmeter[$driver] >= 2) {
@@ -332,35 +328,6 @@ protected static function validateDriverClass(string $driverClass): string
         return $driverClass;
     }
 
-    /**
-     * @param string $driver
-     * @param ConfigurationOption $config
-     * @param PhpfastcacheDriverCheckException $e
-     * @return ExtendedCacheItemPoolInterface
-     * @throws PhpfastcacheDriverCheckException
-     * @throws PhpfastcacheDriverException
-     * @throws PhpfastcacheDriverNotFoundException
-     * @throws PhpfastcacheInvalidConfigurationException
-     * @throws PhpfastcacheLogicException
-     * @throws \ReflectionException
-     */
-    protected static function getFallbackInstance(string $driver, ConfigurationOption $config, PhpfastcacheDriverCheckException $e): ExtendedCacheItemPoolInterface
-    {
-        if ($config->getFallback()) {
-            try {
-                $fallback = $config->getFallback();
-                $config->setFallback('');
-                trigger_error(sprintf('The "%s" driver is unavailable at the moment, the fallback driver "%s" has been used instead.', $driver,
-                    $fallback), E_USER_WARNING);
-                return self::getInstance($fallback, $config->getFallbackConfig());
-            } catch (PhpfastcacheInvalidArgumentException $e) {
-                throw new PhpfastcacheInvalidConfigurationException('Invalid fallback driver configuration', 0, $e);
-            }
-        } else {
-            throw new PhpfastcacheDriverCheckException($e->getMessage(), $e->getCode(), $e);
-        }
-    }
-
     /**
      * @return bool
      */

lib/Phpfastcache/Cluster/Drivers/RandomReplication/RandomReplicationCluster.php

@@ -31,20 +31,16 @@
 class RandomReplicationCluster extends MasterSlaveReplicationCluster
 {
     /**
-     * MasterSlaveReplicationCluster constructor.
+     * RandomReplicationCluster constructor.
      * @param string $clusterName
      * @param ExtendedCacheItemPoolInterface ...$driverPools
-     * @throws PhpfastcacheInvalidArgumentException
-     * @throws PhpfastcacheDriverCheckException
-     * @throws PhpfastcacheDriverConnectException
-     * @throws PhpfastcacheInvalidConfigurationException
      * @throws ReflectionException
      */
     public function __construct(string $clusterName, ExtendedCacheItemPoolInterface ...$driverPools)
     {
-        (new ReflectionMethod(get_parent_class(get_parent_class($this)), __FUNCTION__))
+        (new ReflectionMethod(\get_parent_class(\get_parent_class($this)), __FUNCTION__))
             ->invoke($this, $clusterName, ...$driverPools);
-        $randomPool = $driverPools[random_int(0, count($driverPools) - 1)];
+        $randomPool = $driverPools[\random_int(0, \count($driverPools) - 1)];
         $this->clusterPools = [$randomPool];
     }
 

lib/Phpfastcache/Config/ConfigurationOption.php

@@ -40,12 +40,6 @@ class ConfigurationOption extends ArrayObject implements ConfigurationOptionInte
      */
     protected $autoTmpFallback = false;
 
-    /**
-     * @var bool
-     * @deprecated Do not use this option anymore
-     */
-    protected $ignoreSymfonyNotice = false;
-
     /**
      * @var int
      */
@@ -71,16 +65,6 @@ class ConfigurationOption extends ArrayObject implements ConfigurationOptionInte
      */
     protected $path = '';
 
-    /**
-     * @var string
-     */
-    protected $fallback = '';
-
-    /**
-     * @var ConfigurationOption
-     */
-    protected $fallbackConfig;
-
     /**
      * @var int
      */
@@ -163,17 +147,6 @@ public function __construct(...$args)
         }
     }
 
-    /**
-     * @param string $optionName
-     * @return mixed|null
-     * @deprecated Use ->getOptionName() instead
-     */
-    public function getOption(string $optionName)
-    {
-        trigger_error(sprintf('Method "%s" is deprecated, use "getOptionName()" instead', __METHOD__), E_USER_DEPRECATED);
-        return $this->$optionName ?? null;
-    }
-
     /**
      * @param string $optionName
      * @return mixed|null
@@ -219,29 +192,6 @@ public function setAutoTmpFallback(bool $autoTmpFallback): self
         return $this;
     }
 
-    /**
-     * @return bool
-     * @deprecated As of V7
-     */
-    public function isIgnoreSymfonyNotice(): bool
-    {
-        return $this->ignoreSymfonyNotice;
-    }
-
-    /**
-     * @param bool $ignoreSymfonyNotice
-     * @return ConfigurationOption
-     * @deprecated As of V7
-     */
-    public function setIgnoreSymfonyNotice(bool $ignoreSymfonyNotice): self
-    {
-        if ($ignoreSymfonyNotice) {
-            trigger_error('Configuration option "ignoreSymfonyNotice" is deprecated as of the V7', E_USER_DEPRECATED);
-        }
-        $this->ignoreSymfonyNotice = $ignoreSymfonyNotice;
-        return $this;
-    }
-
     /**
      * @return int
      */
@@ -340,50 +290,6 @@ public function setPath(string $path): self
         return $this;
     }
 
-    /**
-     * @return bool|string
-     */
-    public function getFallback()
-    {
-        return $this->fallback;
-    }
-
-    /**
-     * @param string $fallback
-     * @return ConfigurationOption
-     */
-    public function setFallback(string $fallback): self
-    {
-        $this->fallback = $fallback;
-        return $this;
-    }
-
-    /**
-     * @return ConfigurationOption|null
-     */
-    public function getFallbackConfig()
-    {
-        return $this->fallbackConfig;
-    }
-
-    /**
-     * @param ConfigurationOption|null $fallbackConfig
-     * @return ConfigurationOption
-     * @throws PhpfastcacheInvalidArgumentException
-     */
-    public function setFallbackConfig($fallbackConfig): self
-    {
-        if ($fallbackConfig !== null && !($fallbackConfig instanceof self)) {
-            throw new PhpfastcacheInvalidArgumentException(sprintf(
-                'Invalid argument "%s" for %s',
-                is_object($fallbackConfig) ? get_class($fallbackConfig) : gettype($fallbackConfig),
-                __METHOD__
-            ));
-        }
-        $this->fallbackConfig = $fallbackConfig;
-        return $this;
-    }
-
     /**
      * @return int
      */
@@ -455,4 +361,4 @@ public function setCacheSlamsTimeout(int $cacheSlamsTimeout): self
         $this->cacheSlamsTimeout = $cacheSlamsTimeout;
         return $this;
     }
-}
+}

lib/Phpfastcache/Config/ConfigurationOptionInterface.php

@@ -24,16 +24,9 @@ interface ConfigurationOptionInterface
      */
     public function __construct(...$args);
 
-    /**
-     * @param string $optionName
-     * @return mixed|null
-     * @deprecated Use ->getOptionName() instead
-     */
-    public function getOption(string $optionName);
-
     /**
      * @param string $optionName
      * @return mixed|null
      */
     public function isValidOption(string $optionName);
-}
+}