Don't use detached or shell for spawn, use terminate

Author: DiegoRBaquero

package-lock.json

@@ -39,6 +39,7 @@
     "pretty-ms": "^3.1.0",
     "recursive-copy": "^2.0.9",
     "strip-ansi": "^4.0.0",
+    "terminate": "^2.1.0",
     "yargs": "^9.0.1"
   },
   "devDependencies": {

package.json

@@ -3,6 +3,7 @@ const spawn = require('child_process').spawn
 const Debug = require('debug')
 const fs = require('fs')
 const path = require('path')
+const terminate = require('terminate')
 
 /**
  * @module MutantRunner
@@ -16,19 +17,14 @@ module.exports = function MutantRunner ({mutodeInstance, filePath, contentToWrit
     await new Promise(resolve => {
       const startTime = process.hrtime()
       fs.writeFileSync(`.mutode/mutode-${mutodeInstance.id}-${index}/${filePath}`, contentToWrite)
-      const child = spawn(mutodeInstance.npmCommand, ['test'], {
-        cwd: path.resolve(`.mutode/mutode-${mutodeInstance.id}-${index}`),
-        detached: true,
-        shell: true
-      })
+      const child = spawn(mutodeInstance.npmCommand, ['test'], {cwd: path.resolve(`.mutode/mutode-${mutodeInstance.id}-${index}`)})
 
       child.stderr.on('data', data => {
         debug(data.toString())
       })
 
       const timeout = setTimeout(() => {
-        child.kill('SIGKILL')
-        process.kill(-child.pid)
+        terminate(child.pid)
       }, mutodeInstance.timeout).unref()
 
       child.on('exit', (code, signal) => {

src/mutantRunner.js

@@ -208,7 +208,7 @@ class Mutode {
   async timeCleanTests () {
     console.log(`Verifying and timing your test suite`)
     const start = +new Date()
-    const child = spawn(this.npmCommand, ['test'], {cwd: path.resolve(`.mutode/mutode-${this.id}-0`), shell: true})
+    const child = spawn(this.npmCommand, ['test'], {cwd: path.resolve(`.mutode/mutode-${this.id}-0`)})
 
     child.stderr.on('data', data => {
       debug(data.toString())