BUGFIX: tell the json parser in stack load to treat jinja templates as strings

our current json parser will attempt to interpret things between double curly braces - some json thing.

Author: bsanders

common/src/stack/command/stack/commands/load/__init__.py

@@ -24,9 +24,9 @@ class command(stack.commands.Command):
 	MustBeRoot = 0
 
 	def _load(self, text):
-		parser = JsonComment(json) # standard JSON is stupid
+		parser = JsonComment() # standard JSON is stupid
 		try:
-			data = parser.loads(text)
+			data = parser.loads(text, template=False)
 		except ValueError as e:
 			# parse the error message and split the input at the
 			# syntax error
@@ -106,6 +106,7 @@ def load_file(self, filename):
 			data = fin.read()
 		except IOError:
 			raise CommandError(self, f'cannot read {filename}')
+
 		document = self._load(data)
 		if scope == 'global':
 			return document

test-framework/test-suites/integration/files/load/json/network_with_jinja.json

@@ -0,0 +1,14 @@
+{
+  "network": [
+    {
+      "name": "bogus",
+      "address": "10.35.100.0",
+      "gateway": null,
+      "netmask": "255.255.255.0",
+      "dns": false,
+      "pxe": false,
+      "mtu": 65492,
+      "zone": "{{ fake }}"
+    }
+  ]
+}

test-framework/test-suites/integration/tests/load/test_load.py

@@ -165,3 +165,13 @@ def test_load_cart(self, host, test_file):
 			/opt/stack/bin/stack "add box" test os=sles
 			/opt/stack/bin/stack "enable cart" test box=test
 		''')
+
+
+	def test_load_json_with_jinja(self, host, test_file):
+		""" test that the json parser doesn't swallow jinja templates """
+		json_path = Path(test_file("load/json/network_with_jinja.json"))
+
+		result = host.run(f'stack load {json_path}')
+		assert result.rc == 0
+		assert result.stdout.lstrip().startswith('''/opt/stack/bin/stack "add network" bogus''')
+		assert "zone='{{ fake }}'" in result.stdout