fix(react-router): correct typing for getRouteApi` (#2438)

* fix(react-router): correct typing for `getRouteApi``

* chore: fix type tests

---------

Co-authored-by: chorobin <chrishorobin@hotmail.com>

Author: schiller-manuel

packages/react-router/src/route.ts

@@ -750,22 +750,18 @@ export type RouteConstraints = {
   TRouteTree: AnyRoute
 }
 
-export type RouteTypesById<
-  TRouter extends RegisteredRouter,
-  TId extends RouteIds<TRouter['routeTree']>,
-> = RouteById<TRouter['routeTree'], TId>['types']
-
-export function getRouteApi<
-  TRouter extends RegisteredRouter,
-  TId extends RouteIds<TRouter['routeTree']>,
->(id: TId) {
-  return new RouteApi<TRouter, TId>({ id })
+export type RouteTypesById<TRouter extends AnyRouter, TId> = RouteById<
+  TRouter['routeTree'],
+  TId
+>['types']
+
+export function getRouteApi<TId, TRouter extends AnyRouter = RegisteredRouter>(
+  id: Constrain<TId, RouteIds<TRouter['routeTree']>>,
+) {
+  return new RouteApi<TId, TRouter>({ id })
 }
 
-export class RouteApi<
-  TRouter extends RegisteredRouter,
-  TId extends RouteIds<TRouter['routeTree']>,
-> {
+export class RouteApi<TId, TRouter extends AnyRouter = RegisteredRouter> {
   id: TId
 
   /**

packages/react-router/tests/routeApi.test-d.tsx

@@ -43,7 +43,7 @@ type ExtractDefaultFrom<T> =
   T extends UseNavigateResult<infer DefaultFrom> ? DefaultFrom : never
 
 describe('getRouteApi', () => {
-  const invoiceRouteApi = getRouteApi<DefaultRouter, '/invoices/$invoiceId'>(
+  const invoiceRouteApi = getRouteApi<'/invoices/$invoiceId', DefaultRouter>(
     '/invoices/$invoiceId',
   )
   describe('useNavigate', () => {