refactor: restructure into Cargo workspace + bug fixes

- Restructure into workspace: shared (lib) + recorder (bin)
- P0: fix unwrap panic on non-UTF-8 paths in converter
- P0: fix division by zero when segment_duration=0
- P0: quote ExecStart paths in systemd service
- P1: cleanup partial MP4 on failed conversion
- P1: ensure ffmpeg tmp dir cleanup on extraction failure
- P1: log unexpected background task termination
- P1: validate GCS credential path
- P2: improve error logging in uploader and cleanup
- HEVC streams now re-encoded to H.264 for Linux compatibility

Author: NieMoOxO

README.md

@@ -243,8 +243,9 @@ nohup rtsp-recorder --daemon &
   │   ├─ H.265 → copy + hvc1 tag
   │   └─ MJPEG → re-encode to H.264
   │
-  └─ 智慧上傳到 GCS（網路閒置時）
-      └─ 上傳後依 retention.max_hours 清理
+  ├─ 智慧上傳到 GCS（網路閒置時）
+  │
+  └─ 自動清理舊檔（依 retention.max_hours）
 ```
 
 ---

rust/Cargo.lock

@@ -1,39 +1,15 @@
-[package]
-name = "rtsp-recorder"
-version = "0.1.0"
+[workspace]
+members = [
+    "crates/shared",
+    "crates/recorder",
+]
+resolver = "2"
+
+[workspace.package]
+version = "0.4.0"
 edition = "2021"
-description = "RTSP recorder with GCS upload support"
 authors = ["Daniel Chen"]
 
-[dependencies]
-# CLI 參數解析
-clap = { version = "4", features = ["derive"] }
-
-# 非同步運行時
-tokio = { version = "1", features = ["full"] }
-
-# 設定檔解析
-serde = { version = "1", features = ["derive"] }
-serde_yaml = "0.9"
-serde_json = "1"
-
-# 時間處理
-chrono = { version = "0.4", features = ["serde"] }
-
-# 日誌
-tracing = "0.1"
-tracing-subscriber = { version = "0.3", features = ["env-filter"] }
-
-# GCS 上傳（使用 rustls 避免 OpenSSL 依賴）
-cloud-storage = { version = "0.11", default-features = false, features = ["rustls-tls"] }
-
-# 錯誤處理
-anyhow = "1"
-thiserror = "1"
-
-# 目錄路徑
-dirs = "5"
-
 [profile.release]
 opt-level = 3
 lto = true

rust/Cargo.toml

@@ -0,0 +1,31 @@
+[package]
+name = "rtsp-recorder"
+version = "0.4.0"
+edition = "2021"
+description = "RTSP recorder with GCS upload support"
+authors = ["Daniel Chen"]
+
+[dependencies]
+rtsp-shared = { path = "../shared" }
+
+# CLI 參數解析
+clap = { version = "4", features = ["derive"] }
+
+# 非同步運行時
+tokio = { version = "1", features = ["full"] }
+
+# 設定檔解析
+serde_json = "1"
+
+# 時間處理
+chrono = "0.4"
+
+# 日誌
+tracing = "0.1"
+tracing-subscriber = { version = "0.3", features = ["env-filter"] }
+
+# 錯誤處理
+anyhow = "1"
+
+# 目錄路徑
+dirs = "5"

rust/crates/recorder/Cargo.toml

@@ -4,13 +4,10 @@ use std::path::PathBuf;
 use std::sync::Arc;
 use tokio::sync::Mutex;
 
-mod config;
-mod converter;
-mod ffmpeg;
+use rtsp_shared::{config, ffmpeg, stats, uploader};
+
 mod recorder;
 mod setup;
-mod stats;
-mod uploader;
 
 #[derive(Parser)]
 #[command(name = "rtsp-recorder")]
@@ -56,21 +53,26 @@ enum Commands {
     Check,
     /// 互動式初始設定
     Setup,
+    /// 解除安裝（清理服務、錄影、設定）
+    Uninstall,
 }
 
 #[tokio::main]
 async fn main() -> Result<()> {
     // 初始化日誌
     tracing_subscriber::fmt()
-        .with_env_filter("rtsp_recorder=info")
+        .with_env_filter("rtsp_recorder=info,rtsp_shared=info")
         .init();
 
     let cli = Cli::parse();
 
-    // Setup 不需要事先存在 config
+    // Setup / Uninstall 不需要事先存在 config
     if matches!(cli.command, Some(Commands::Setup)) {
         return setup::run_setup_wizard(&cli.config).await;
     }
+    if matches!(cli.command, Some(Commands::Uninstall)) {
+        return setup::run_uninstall(&cli.config).await;
+    }
 
     // 載入設定（如果 config 不存在，引導使用者執行 setup）
     let config = match config::Config::load(&cli.config) {
@@ -88,6 +90,15 @@ async fn main() -> Result<()> {
     };
     tracing::info!("已載入設定檔: {:?}", cli.config);
 
+    // P0: 設定 GCS 憑證環境變數（程式啟動時設定一次，避免多執行緒 data race）
+    if config.gcs.credentials.exists() {
+        let cred_path = config.gcs.credentials.to_string_lossy().to_string();
+        if cred_path.is_empty() {
+            anyhow::bail!("GCS 憑證路徑無效: {:?}", config.gcs.credentials);
+        }
+        std::env::set_var("SERVICE_ACCOUNT", &cred_path);
+    }
+
     // 載入或建立統計
     let stats = Arc::new(Mutex::new(
         stats::Stats::load(&config.output.dir).unwrap_or_default()
@@ -119,6 +130,7 @@ async fn main() -> Result<()> {
             check_environment(&config, &cli.config).await?;
         }
         Some(Commands::Setup) => unreachable!(), // 已在上方處理
+        Some(Commands::Uninstall) => unreachable!(), // 已在上方處理
         None => {
             if cli.daemon {
                 let ff = ffmpeg::ensure_ffmpeg().await?;
@@ -267,7 +279,7 @@ async fn cleanup_old_files(
             continue;
         }
 
-        if let Ok(metadata) = path.metadata() {
+        if let Ok(metadata) = entry.metadata() {
             if let Ok(modified) = metadata.modified() {
                 if modified < threshold {
                     if let Err(e) = std::fs::remove_file(&path) {