From c83b61db5220e1a52c8dc257f119120f08a8dfef Mon Sep 17 00:00:00 2001 From: Thomas Jakobi Date: Thu, 24 Oct 2019 09:25:44 +0200 Subject: [PATCH] A plugin should not return any value This should avoid such errors in the MODX error log: ``` [2019-10-23 15:08:12] (ERROR @ /.../revolution/core/model/modx/modx.class.php : 1671) [OnMODXInit]1 ``` --- core/components/seopro/elements/plugins/seopro.plugin.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/components/seopro/elements/plugins/seopro.plugin.php b/core/components/seopro/elements/plugins/seopro.plugin.php index c9e79ea..92aba56 100644 --- a/core/components/seopro/elements/plugins/seopro.plugin.php +++ b/core/components/seopro/elements/plugins/seopro.plugin.php @@ -6,7 +6,7 @@ */ $seoPro = $modx->getService('seopro', 'seoPro', $modx->getOption('seopro.core_path', null, $modx->getOption('core_path') . 'components/seopro/') . 'model/seopro/', $scriptProperties); if (!($seoPro instanceof seoPro)) { - return ''; + return; } $disabledTemplates = explode(',', $modx->getOption('seopro.disabledtemplates', null, '0')); @@ -190,4 +190,4 @@ } $modx->setPlaceholder('seoPro.title', $title); break; -} \ No newline at end of file +}