#2025: Fix reverting with nested sortables

owen-m1 · owen-m1 · commit 0a1bab7bbe1e · 2021-05-08T17:51:14.000-04:00
diff --git a/src/Sortable.js b/src/Sortable.js
@@ -1131,7 +1131,7 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
 
 		if (activeSortable && !options.disabled &&
 			(isOwner
-				? canSort || (revert = !rootEl.contains(dragEl)) // Reverting item into the original list
+				? canSort || (revert = parentEl !== rootEl) // Reverting item into the original list
 				: (
 					putSortable === this ||
 					(

Original file line number	Diff line number	Diff line change
`@@ -1131,7 +1131,7 @@ Sortable.prototype = /** @lends Sortable.prototype */ {`
`1131`	`1131`
`1132`	`1132`	`if (activeSortable && !options.disabled &&`
`1133`	`1133`	`(isOwner`
`1134`		`- ? canSort \|\| (revert = !rootEl.contains(dragEl)) // Reverting item into the original list`
	`1134`	`+ ? canSort \|\| (revert = parentEl !== rootEl) // Reverting item into the original list`
`1135`	`1135`	`: (`
`1136`	`1136`	`putSortable === this \|\|`
`1137`	`1137`	`(`