Skip to content

Commit 0738f37

Browse files
committed
#1517: Mark Chrome for Android as not supporting native DnD
1 parent 2ca1ff5 commit 0738f37

2 files changed

Lines changed: 9 additions & 16 deletions

File tree

src/BrowserInfo.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
11
function userAgent(pattern) {
2-
return !!navigator.userAgent.match(pattern);
2+
return !!/*@__PURE__*/navigator.userAgent.match(pattern);
33
}
44

5-
const IE11OrLess = /*@__PURE__*/userAgent(/(?:Trident.*rv[ :]?11\.|msie|iemobile|Windows Phone)/i);
6-
const Edge = /*@__PURE__*/userAgent(/Edge/i);
7-
const FireFox = /*@__PURE__*/userAgent(/firefox/i);
8-
const Safari = /*@__PURE__*/userAgent(/safari/i) && !userAgent(/chrome/i) && !userAgent(/android/i);
9-
const IOS = /*@__PURE__*/userAgent(/iP(ad|od|hone)/i);
10-
11-
export {
12-
IE11OrLess,
13-
Edge,
14-
FireFox,
15-
Safari,
16-
IOS
17-
};
5+
export const IE11OrLess = userAgent(/(?:Trident.*rv[ :]?11\.|msie|iemobile|Windows Phone)/i);
6+
export const Edge = userAgent(/Edge/i);
7+
export const FireFox = userAgent(/firefox/i);
8+
export const Safari = userAgent(/safari/i) && !userAgent(/chrome/i) && !userAgent(/android/i);
9+
export const IOS = userAgent(/iP(ad|od|hone)/i);
10+
export const ChromeForAndroid = userAgent(/chrome/i) && userAgent(/android/i);

src/Sortable.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import { version } from '../package.json';
99

10-
import { IE11OrLess, Edge, FireFox, Safari, IOS } from './BrowserInfo.js';
10+
import { IE11OrLess, Edge, FireFox, Safari, IOS, ChromeForAndroid } from './BrowserInfo.js';
1111

1212
import AnimationStateManager from './Animation.js';
1313

@@ -143,7 +143,7 @@ let dragEl,
143143
CSSFloatProperty = Edge || IE11OrLess ? 'cssFloat' : 'float',
144144

145145
// This will not pass for IE9, because IE9 DnD only works on anchors
146-
supportDraggable = ('draggable' in document.createElement('div')),
146+
supportDraggable = !ChromeForAndroid && ('draggable' in document.createElement('div')),
147147

148148
supportCssPointerEvents = (function() {
149149
// false when <= IE11

0 commit comments

Comments
 (0)