[BUG] Ice spell has no upper limit and can cause server crashes

[server-ok]

Describe the bug

we're playing on a server and my friend made a spell...

...well, it certainly couldn't go well. Either an eternal winter or a server crash. It was the latter.
I looked at the code, and well, i don't think there's a limit :c

Expected behavior
Server doesn't crash. Either the spell's range is limited, or block calculations span multiple ticks to not trigger server's 60s/tick death.

Steps to reproduce
Make an ice spell and keep adding element of power. Use spell.

Screenshots
Screenshot was at the top.

Version Information:

• Minecraft Version: 1.21.1
• Unicopia Version: Unicopia 1.3.20 (BETA2) with segmentedCropBlock patched for getAvailableMoisture() and getGrowthSpeed() crash Sinytra/Connector#2255 (comment)

Mod Loader:

• Fabric
• Quilt
• Neoforge (with connector)

Client/Server Logs
There were no logs duing the spell, the server just silently timed out.

[server-ok]

p.s

this spell also can lag the game when casted, i think it has no upper limit on entity effect range and maybe on block effect range too, but it isn't that much noticeable in-game for some reason.
There may be more spells like that..

[Sollace]

p.s this spell also can lag the game when casted, i think it has no upper limit on entity effect range and maybe on block effect range too, but it isn't that much noticeable in-game for some reason. There may be more spells like that..

32 is the max for that spell type. Ice spells are properly uncapped which is a bug.

[server-ok]

thanks :)

[server-ok]

seems like at least the ice spell only executes 1 tick of random block spawn, and has a minimum of 30 range instead of 3

[Sollace]

seems like at least the ice spell only executes 1 tick of random block spawn, and has a minimum of 30 range instead of 3

Oh yeah thanks for pointing that out.