feat(quality-scan): add documentation accuracy scan

Add comprehensive documentation accuracy verification to quality-scan skill:

**New Scan Type: documentation**
- Verifies README files against actual codebase implementation
- Checks package names, command examples, API docs, file paths
- Identifies outdated examples and missing documentation
- Reports incorrect configuration formats and wrong version info

**Pattern Detection:**
- Package names not matching package.json
- Commands with non-existent flags
- File paths that don't exist
- APIs documented but not exported
- Config examples with wrong structure
- Build outputs in wrong locations
- Missing documentation for major features (75%+ of package)

**Severity Levels:**
- High: Critical errors (wrong commands, non-existent APIs)
- Medium: Outdated info (wrong paths, old examples)
- Low: Minor inaccuracies (version numbers, sizes)

Follows Claude best practices with structured <context>, <instructions>, <pattern>, and <output_format> tags.

Author: jdalton

.claude/skills/quality-scan/SKILL.md

@@ -6,27 +6,28 @@ description: Performs comprehensive quality scans across codebase to identify cr
 # quality-scan
 
 <task>
-Your task is to perform comprehensive quality scans across the socket-lib codebase using specialized agents to identify critical bugs, logic errors, caching issues, and workflow problems. Generate a prioritized report with actionable improvement tasks.
+Your task is to perform comprehensive quality scans across the socket-btm codebase using specialized agents to identify critical bugs, logic errors, caching issues, and workflow problems. Generate a prioritized report with actionable improvement tasks.
 </task>
 
 <context>
 **What is Quality Scanning?**
 Quality scanning uses specialized AI agents to systematically analyze code for different categories of issues. Each agent type focuses on specific problem domains and reports findings with severity levels and actionable fixes.
 
-**socket-lib Architecture:**
-Core utilities and infrastructure library for Socket.dev security tools that:
-- Provides shared utilities used across Socket.dev projects
-- Contains logger, fs helpers, process utilities
-- Manages build infrastructure and tooling
-- Provides testing utilities and helpers
-- Supports cross-platform compatibility
+**socket-btm Architecture:**
+This is Socket Security's binary tooling manager (BTM) that:
+- Builds custom Node.js binaries with Socket Security patches
+- Manages Node.js versions and patch synchronization
+- Produces minimal Node.js builds (node-smol-builder)
+- Processes upstream Node.js source code and applies security patches
+- Supports production deployments with patched Node.js
 
 **Scan Types Available:**
 1. **critical** - Crashes, security vulnerabilities, resource leaks, data corruption
 2. **logic** - Algorithm errors, edge cases, type guards, off-by-one errors
 3. **cache** - Cache staleness, race conditions, invalidation bugs
 4. **workflow** - Build scripts, CI issues, cross-platform compatibility
 5. **security** - GitHub Actions workflow security (zizmor scanner)
+6. **documentation** - README accuracy, outdated docs, missing documentation
 
 **Why Quality Scanning Matters:**
 - Catches bugs before they reach production
@@ -54,7 +55,7 @@ All agent prompts are embedded in `reference.md` with structured <context>, <ins
 - Proceed if codebase has uncommitted changes (warn but continue)
 
 **Do ONLY:**
-- Run enabled scan types in priority order (critical → logic → cache → workflow → security)
+- Run enabled scan types in priority order (critical → logic → cache → workflow)
 - Generate structured findings with severity levels
 - Provide actionable improvement tasks with specific code changes
 - Report statistics and coverage metrics
@@ -103,14 +104,15 @@ Ask user which scans to run:
 3. **cache** - Caching issues (staleness, races, invalidation)
 4. **workflow** - Workflow problems (scripts, CI, git hooks)
 5. **security** - GitHub Actions security (template injection, cache poisoning, etc.)
+6. **documentation** - Documentation accuracy (README errors, outdated docs)
 
 **User Interaction:**
 Use AskUserQuestion tool:
 - Question: "Which quality scans would you like to run?"
 - Header: "Scan Types"
 - multiSelect: true
 - Options:
-  - "All scans (recommended)" → Run all 5 scan types
+  - "All scans (recommended)" → Run all 4 scan types
   - "Critical only" → Run critical scan only
   - "Critical + Logic" → Run critical and logic scans
   - "Custom selection" → Ask user to specify which scans
@@ -124,6 +126,7 @@ Validate selected scan types exist in reference.md:
 - cache-scan → reference.md line ~200
 - workflow-scan → reference.md line ~300
 - security-scan → reference.md line ~400
+- documentation-scan → reference.md line ~810
 
 If user requests non-existent scan type, report error and suggest valid types.
 </validation>
@@ -143,7 +146,7 @@ Task({
   description: "Critical bugs scan",
   prompt: `${CRITICAL_SCAN_PROMPT_FROM_REFERENCE_MD}
 
-Focus on src/, packages/.
+Focus on packages/node-smol-builder/ directory and root-level scripts/.
 
 Report findings in this format:
 - File: path/to/file.mts:lineNumber
@@ -160,7 +163,7 @@ Scan systematically and report all findings. If no issues found, state that expl
 
 **For each scan:**
 1. Load agent prompt template from `reference.md`
-2. Customize for socket-lib context (focus on src/, packages/)
+2. Customize for socket-btm context (focus on packages/node-smol-builder/, scripts/, patches/)
 3. Spawn agent with Task tool using "general-purpose" subagent_type
 4. Capture findings from agent response
 5. Parse and categorize results
@@ -169,15 +172,15 @@ Scan systematically and report all findings. If no issues found, state that expl
 - critical (highest priority)
 - logic
 - cache
-- workflow
-- security (lowest priority)
+- workflow (lowest priority)
 
 **Agent Prompt Sources:**
 - Critical scan: reference.md starting at line ~12
 - Logic scan: reference.md starting at line ~100
 - Cache scan: reference.md starting at line ~200
 - Workflow scan: reference.md starting at line ~300
 - Security scan: reference.md starting at line ~400
+- Documentation scan: reference.md starting at line ~810
 
 <validation>
 For each scan completion:
@@ -197,7 +200,7 @@ Collect all findings from agents and aggregate:
 
 ```typescript
 interface Finding {
-  file: string           // "src/api/client.mts:89"
+  file: string           // "packages/node-smol-builder/src/patcher.mts:89"
   issue: string          // "Potential null pointer access"
   severity: "Critical" | "High" | "Medium" | "Low"
   scanType: string       // "critical"
@@ -238,19 +241,19 @@ Create structured quality report with all findings:
 # Quality Scan Report
 
 **Date:** YYYY-MM-DD
-**Repository:** socket-lib
+**Repository:** socket-btm
 **Scans:** [list of scan types run]
 **Files Scanned:** N
 **Findings:** N critical, N high, N medium, N low
 
 ## Critical Issues (Priority 1) - N found
 
-### src/api/client.mts:89
-- **Issue**: Potential null pointer access when calling API
-- **Pattern**: `const result = response.data.items[0].value`
-- **Trigger**: When API returns empty items array
-- **Fix**: `const items = response.data?.items ?? []; const value = items[0]?.value ?? null`
-- **Impact**: Crashes API client, breaks user workflows
+### packages/node-smol-builder/src/patcher.mts:89
+- **Issue**: Potential null pointer access when applying patches
+- **Pattern**: `const result = patches[index].apply()`
+- **Trigger**: When patch array has fewer elements than expected
+- **Fix**: `const patch = patches[index]; if (!patch) throw new Error('Patch not found'); const result = patch.apply()`
+- **Impact**: Crashes patch application process, build fails
 - **Scan**: critical
 
 ## High Issues (Priority 2) - N found
@@ -267,16 +270,15 @@ Create structured quality report with all findings:
 
 ## Scan Coverage
 
-- **Critical scan**: N files analyzed in src/, packages/
-- **Logic scan**: N files analyzed
+- **Critical scan**: N files analyzed in packages/node-smol-builder/, scripts/
+- **Logic scan**: N files analyzed (patch logic, build scripts)
 - **Cache scan**: N files analyzed (if applicable)
 - **Workflow scan**: N files analyzed (package.json, scripts/, .github/)
-- **Security scan**: N workflow files analyzed (.github/workflows/)
 
 ## Recommendations
 
 1. Address N critical issues immediately before next release
-2. Review N high-severity logic errors
+2. Review N high-severity logic errors in patch application
 3. Schedule N medium issues for next sprint
 4. Low-priority items can be addressed during refactoring
 
@@ -285,7 +287,6 @@ Create structured quality report with all findings:
 [If a scan found no issues, list it here:]
 - Critical scan: ✓ Clean
 - Logic scan: ✓ Clean
-- Security scan: ✓ Clean
 ```
 
 **Output Report:**
@@ -356,6 +357,7 @@ See `reference.md` for detailed agent prompts with structured tags:
 - **cache-scan** - Invalidation, key generation, memory management, concurrency
 - **workflow-scan** - Scripts, package.json, git hooks, CI configuration
 - **security-scan** - GitHub Actions workflow security (runs zizmor scanner)
+- **documentation-scan** - README accuracy, outdated examples, incorrect package names, missing documentation
 
 All agent prompts follow Claude best practices with <context>, <instructions>, <pattern>, <output_format>, and <quality_guidelines> tags.
 
@@ -365,7 +367,7 @@ This skill is self-contained. No external commands needed.
 
 ## Context
 
-This skill provides systematic code quality analysis for socket-lib by:
+This skill provides systematic code quality analysis for socket-btm by:
 - Spawning specialized agents for targeted analysis
 - Using Task tool to run agents autonomously
 - Embedding agent prompts in reference.md following best practices