Skip to content

Commit e885361

Browse files
committed
Improve error messages
1 parent f019625 commit e885361

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/torchjd/sparse/_structured_sparse_tensor.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,19 @@ def __init__(self, physical: Tensor, strides: Tensor):
5959
raise ValueError(f"All strides must be non-negative. Found strides={strides}.")
6060
if strides.shape[1] != physical.ndim:
6161
raise ValueError(
62-
f"strides should have 1 column per physical dimension. Found strides={strides} and physical.shape={physical.shape}."
62+
f"strides should have 1 column per physical dimension. Found strides={strides} and "
63+
f"physical.shape={physical.shape}."
6364
)
6465
if (strides.sum(dim=0) == 0).any():
6566
raise ValueError(
6667
f"strides should not have any column full of zeros. Found strides={strides}."
6768
)
68-
if any(len(group) != 1 for group in get_groupings(list(physical.shape), strides)):
69-
raise ValueError(f"Dimensions must be maximally grouped. Found strides={strides}.")
69+
groups = get_groupings(list(physical.shape), strides)
70+
if any(len(group) != 1 for group in groups):
71+
raise ValueError(
72+
f"Dimensions must be maximally grouped. Found strides={strides} and "
73+
f"groups={groups}"
74+
)
7075

7176
self.physical = physical
7277
self.strides = strides

0 commit comments

Comments
 (0)