update task rendering

Author: ryancbahan

packages/cli-kit/src/public/node/ui.test.ts

@@ -485,18 +485,17 @@ describe('renderSingleTask', async () => {
     await expect(renderSingleTask({title, task})).rejects.toThrow('Delayed failure')
   })
 
-  test('handles concurrent single tasks', async () => {
+  test('handles sequential single tasks', async () => {
     // Given
     const task1 = () => new Promise((resolve) => setTimeout(() => resolve('result1'), 50))
     const task2 = () => new Promise((resolve) => setTimeout(() => resolve('result2'), 100))
     const task3 = () => new Promise((resolve) => setTimeout(() => resolve('result3'), 25))
 
-    // When
-    const [result1, result2, result3] = await Promise.all([
-      renderSingleTask({title: new TokenizedString('Task 1'), task: task1}),
-      renderSingleTask({title: new TokenizedString('Task 2'), task: task2}),
-      renderSingleTask({title: new TokenizedString('Task 3'), task: task3}),
-    ])
+    // When — ink only supports one render instance per stdout at a time,
+    // so sequential execution is the correct pattern
+    const result1 = await renderSingleTask({title: new TokenizedString('Task 1'), task: task1})
+    const result2 = await renderSingleTask({title: new TokenizedString('Task 2'), task: task2})
+    const result3 = await renderSingleTask({title: new TokenizedString('Task 3'), task: task3})
 
     // Then
     expect(result1).toBe('result1')

packages/cli-kit/src/public/node/ui.tsx

@@ -487,14 +487,21 @@ export async function renderTasks<TContext>(
   tasks: Task<TContext>[],
   {renderOptions, noProgressBar}: RenderTasksOptions = {},
 ) {
-  return new Promise<TContext>((resolve, reject) => {
-    render(<Tasks tasks={tasks} onComplete={resolve} noProgressBar={noProgressBar} />, {
+  let taskResult: TContext
+  await render(
+    <Tasks
+      tasks={tasks}
+      onComplete={(ctx) => {
+        taskResult = ctx
+      }}
+      noProgressBar={noProgressBar}
+    />,
+    {
       ...renderOptions,
       exitOnCtrlC: false,
-    })
-      .then(() => {})
-      .catch(reject)
-  })
+    },
+  )
+  return taskResult!
 }
 
 export interface RenderSingleTaskOptions<T> {
@@ -521,12 +528,22 @@ export async function renderSingleTask<T>({
   onAbort,
   renderOptions,
 }: RenderSingleTaskOptions<T>): Promise<T> {
-  return new Promise<T>((resolve, reject) => {
-    render(<SingleTask title={title} task={task} onComplete={resolve} onAbort={onAbort} />, {
+  let taskResult: T
+  await render(
+    <SingleTask
+      title={title}
+      task={task}
+      onComplete={(result) => {
+        taskResult = result
+      }}
+      onAbort={onAbort}
+    />,
+    {
       ...renderOptions,
       exitOnCtrlC: false,
-    }).catch(reject)
-  })
+    },
+  )
+  return taskResult!
 }
 
 export interface RenderTextPromptOptions extends Omit<TextPromptProps, 'onSubmit'> {