Skip to content

Commit b3d3055

Browse files
Updated component to version 2.2.12
1 parent 8de3c26 commit b3d3055

8 files changed

Lines changed: 15 additions & 20 deletions

File tree

RELEASE-NOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### Version 2.2.12 - Aug 07, 2017
2+
3+
- **Popup** - Fixed a regression with `popup` in `2.2.11` that caused popups to appear out of place in some cases due to incorrect calculation of `offsetParent` [#5549](https://github.com/Semantic-Org/Semantic-UI/issues/5549) [#5597](https://github.com/Semantic-Org/Semantic-UI/issues/5597) [#5590](https://github.com/Semantic-Org/Semantic-UI/issues/5590)
4+
15
### Version 2.2.11 - July 11, 2017
26

37
- **Popup** - Added `bind clickaway` `bind touch close` `bind close on scroll` behaviors to make it easier for `on: 'manual'` popup to specify behavior

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@
1515
"framework"
1616
],
1717
"license": "MIT",
18-
"version": "2.2.11"
18+
"version": "2.2.12"
1919
}

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* # Semantic UI 2.2.11 - Popup
2+
* # Semantic UI 2.2.12 - Popup
33
* http://github.com/semantic-org/semantic-ui/
44
*
55
*
@@ -126,7 +126,7 @@ module.exports = function(parameters) {
126126
}
127127
if(settings.popup) {
128128
$popup.addClass(className.loading);
129-
$offsetParent = module.get.offsetParent($target);
129+
$offsetParent = module.get.offsetParent();
130130
$popup.removeClass(className.loading);
131131
if(settings.movePopup && module.has.popup() && module.get.offsetParent($popup)[0] !== $offsetParent[0]) {
132132
module.debug('Moving popup to the same offset parent as target');
@@ -140,7 +140,7 @@ module.exports = function(parameters) {
140140
$offsetParent = (settings.inline)
141141
? module.get.offsetParent($target)
142142
: module.has.popup()
143-
? module.get.offsetParent($target)
143+
? module.get.offsetParent($popup)
144144
: $body
145145
;
146146
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "semantic-ui-popup",
3-
"version": "2.2.11",
3+
"version": "2.2.12",
44
"title": "Semantic UI - Popup",
55
"description": "Single component release of popup",
66
"homepage": "http://www.semantic-ui.com",

popup.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* # Semantic UI 2.2.11 - Popup
2+
* # Semantic UI 2.2.12 - Popup
33
* http://github.com/semantic-org/semantic-ui/
44
*
55
*

popup.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* # Semantic UI 2.2.11 - Popup
2+
* # Semantic UI 2.2.12 - Popup
33
* http://github.com/semantic-org/semantic-ui/
44
*
55
*
@@ -125,7 +125,7 @@ $.fn.popup = function(parameters) {
125125
}
126126
if(settings.popup) {
127127
$popup.addClass(className.loading);
128-
$offsetParent = module.get.offsetParent($target);
128+
$offsetParent = module.get.offsetParent();
129129
$popup.removeClass(className.loading);
130130
if(settings.movePopup && module.has.popup() && module.get.offsetParent($popup)[0] !== $offsetParent[0]) {
131131
module.debug('Moving popup to the same offset parent as target');
@@ -139,7 +139,7 @@ $.fn.popup = function(parameters) {
139139
$offsetParent = (settings.inline)
140140
? module.get.offsetParent($target)
141141
: module.has.popup()
142-
? module.get.offsetParent($target)
142+
? module.get.offsetParent($popup)
143143
: $body
144144
;
145145
}

popup.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

popup.min.js

Lines changed: 1 addition & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)