Skip to content

Commit b19d2d3

Browse files
committed
Merge branch 'master' of github.com:Semantic-Org/Semantic-UI into next
2 parents 2a7a90b + 2ec0dd0 commit b19d2d3

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ Although some components will work in IE9, [grids](http://semantic-ui.com/collec
6868
## Community
6969

7070
#### Getting Help
71-
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
71+
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom][Gitter.im Room] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
7272

7373
#### Submitting Bugs and Enhancements
7474
[GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) is for suggesting enhancements and reporting bugs. Before submiting a bug make sure you do the following:
@@ -92,7 +92,7 @@ When adding pull requests, be sure to merge into the [next](https://github.com/S
9292
Resource | Description
9393
--- | --- |
9494
Bugs & Feature Requests | All bug submission **require** a link to a test case, and a set of steps to reproduce the issue. You can make a test case by forking this [JSFiddle](https://jsfiddle.net/ca0rovs3/), then submit your [bug report on GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues)
95-
Live Chat | Join our [Gitter.im Room](https://gitter.im/Semantic-Org/Semantic-UI)
95+
Live Chat | Join our [Gitter.im Room][Gitter.im Room]
9696
Newsletter Updates | Sign up for updates at [semantic-ui.com](http://www.semantic-ui.com)
9797
Additional Resources | Submit a question on [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) or ask our [Google Group](https://groups.google.com/forum/#!forum/semantic-ui)
9898

@@ -110,3 +110,5 @@ Guides & Tutorials | Help write guides and tutorials | [Join the discussion](htt
110110
If you'd like to start a conversation about Semantic feel free to e-mail me at [jack@semantic-ui.com](mailto:jack@semantic-ui.com)
111111

112112
<a href="http://packagequality.com/#?package=semantic-ui"><img src="http://npm.packagequality.com/badge/semantic-ui.png"/></a>
113+
114+
[Gitter.im Room]: https://gitter.im/Semantic-Org/Semantic-UI

RELEASE-NOTES.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
### Version 2.5.0 - Oct 21, 2018
44

5+
**Note**
6+
> Special Note: If you run into any breaking changes with Gulp 4. Please reach out to me at jack@semantic-ui.com with bug reports
7+
58
**Critical Fix**
69
- **CSS** - Fix extra semicolon causing CSS build of Semantic UI to fail compilation with various systems
710

src/definitions/modules/dimmer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ $.fn.dimmer = function(parameters) {
151151

152152
event: {
153153
click: function(event) {
154-
module.verbose('Determining if event occured on dimmer', event);
154+
module.verbose('Determining if event occurred on dimmer', event);
155155
if( $dimmer.find(event.target).length === 0 || $(event.target).is(selector.content) ) {
156156
module.hide();
157157
event.stopImmediatePropagation();

0 commit comments

Comments
 (0)