Skip to content

Commit 403a377

Browse files
committed
Move deprecated icons before normal rules to prevent improper inheritance
1 parent ef77e8d commit 403a377

2 files changed

Lines changed: 22 additions & 10 deletions

File tree

RELEASE-NOTES.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,17 @@
55
**Bug Fixes**
66
- **Search** - Passing in `cache: false` will now affect default settings for `apiSettings` when using a remote endpoint. Previously you would also have to pass in `apiSettings: { cache: false}` as well
77
- **CSS** - Update LESS syntax to be compatible with LESS 3.0 **Thanks @sciyoshi** [#6447](https://github.com/Semantic-Org/Semantic-UI/pull/6447)
8+
- **Icon** - Several icon names have been deprecated due to incompatibility with `transition in` and `transition out` used in animations.
9+
10+
* `linkedin in` is now `linkedin alternate`
11+
* `zoom in` is now `zoom-in`
12+
* `zoom out` is now `zoom-out`
13+
* `sign in` is now `sign-in`
14+
* `sign in alternate` is now `sign-in alternate`
15+
* `sign out` is now `sign-out`
16+
* `sign out alternate` is now `sign-out alternate`
17+
* `log out` is now `logout`
18+
* `in cart` is now `in-cart`
819

920
### Version 2.3.2 - June 18, 2018
1021

src/themes/default/elements/icon.overrides

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,17 @@ for instance `lemon icon` not `lemon outline icon` since there is only one lemon
3131
Icons
3232
*******************************/
3333

34+
/* Deprecated *In/Out Naming Conflict) */
35+
i.icon.linkedin.in:before { content: "\f0e1"; }
36+
i.icon.zoom.in:before { content: "\f00e"; }
37+
i.icon.zoom.out:before { content: "\f010"; }
38+
i.icon.sign.in:before { content: "\f2f6"; }
39+
i.icon.sign.in.alternate:before { content: "\f2f6"; }
40+
i.icon.in.cart:before { content: "\f218"; }
41+
i.icon.log.out:before { content: "\f2f5"; }
42+
i.icon.sign.out:before { content: "\f2f5"; }
43+
i.icon.sign.out.alternate:before { content: "\f2f5"; }
44+
3445
/* Icons */
3546
i.icon.\35 00px:before { content: "\f26e"; }
3647
i.icon.accessible.icon:before { content: "\f368"; }
@@ -861,16 +872,6 @@ i.icon.yoast:before { content: "\f2b1"; }
861872
i.icon.youtube:before { content: "\f167"; }
862873
i.icon.youtube.square:before { content: "\f431"; }
863874

864-
/* Deprecated *In/Out Naming Conflict) */
865-
i.icon.linkedin.in:before { content: "\f0e1"; }
866-
i.icon.zoom.in:before { content: "\f00e"; }
867-
i.icon.sign.in.alternate:before { content: "\f2f6"; }
868-
i.icon.in.cart:before { content: "\f218"; }
869-
i.icon.zoom.out:before { content: "\f010"; }
870-
i.icon.log.out:before { content: "\f2f5"; }
871-
i.icon.sign.out:before { content: "\f2f5"; }
872-
i.icon.sign.out.alternate:before { content: "\f2f5"; }
873-
874875
/* Aliases */
875876
i.icon.chess.rock:before { content: "\f447"; }
876877
i.icon.ordered.list:before { content: "\f0cb"; }

0 commit comments

Comments
 (0)