Skip to content

Test suite shouldn't require internet connection #28

Description

@marcoheisig

More than half of PiSCAT's tests fail if there is no internet connection. This is because the necessary TestData is not shipped with PiSCAT and has to be downloaded first. Even after the test data has been downloaded, there are some tests that still connect to the internet and fail otherwise. This is bad, because it means testing cannot really done in isolation.

Normally I would suggest the test data is simply incorporated into this repository, but with 4.4 GB it is far too large for that. I suggest the test suite is rewritten to use synthetic test data where possible, so that those huge piles of data aren't needed at all.

Doing so would not only aid reproducibility, but probably speed up the test suite quite a bit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions