PR Feedback 1

Author: VaggelisD

sqlmesh/core/console.py

@@ -322,7 +322,12 @@ def log_destructive_change(
 class UnitTestConsole(abc.ABC):
     @abc.abstractmethod
     def log_test_results(self, result: ModelTextTestResult, target_dialect: str) -> None:
-        """Display the test result and output."""
+        """Display the test result and output.
+
+        Args:
+            result: The unittest test result that contains metrics like num success, fails, ect.
+            target_dialect: The dialect that tests were run against. Assumes all tests run against the same dialect.
+        """
 
 
 class Console(
@@ -470,16 +475,6 @@ def plan(
                 fail. Default: False
         """
 
-    @abc.abstractmethod
-    def log_test_results(self, result: ModelTextTestResult, target_dialect: str) -> None:
-        """Display the test result and output.
-
-        Args:
-            result: The unittest test result that contains metrics like num success, fails, ect.
-            output: The generated output from the unittest.
-            target_dialect: The dialect that tests were run against. Assumes all tests run against the same dialect.
-        """
-
     @abc.abstractmethod
     def show_sql(self, sql: str) -> None:
         """Display to the user SQL."""

sqlmesh/core/context.py

@@ -2043,7 +2043,6 @@ def test(
         verbosity: Verbosity = Verbosity.DEFAULT,
         preserve_fixtures: bool = False,
         stream: t.Optional[t.TextIO] = None,
-        log_results: bool = True,
     ) -> ModelTextTestResult:
         """Discover and run model tests"""
         if verbosity >= Verbosity.VERBOSE:
@@ -2066,11 +2065,10 @@ def test(
             default_catalog_dialect=self.config.dialect or "",
         )
 
-        if log_results:
-            self.console.log_test_results(
-                result,
-                self.test_connection_config._engine_adapter.DIALECT,
-            )
+        self.console.log_test_results(
+            result,
+            self.test_connection_config._engine_adapter.DIALECT,
+        )
 
         return result
 
@@ -2498,7 +2496,7 @@ def _run_tests(
         self, verbosity: Verbosity = Verbosity.DEFAULT
     ) -> t.Tuple[ModelTextTestResult, str]:
         test_output_io = StringIO()
-        result = self.test(stream=test_output_io, verbosity=verbosity, log_results=False)
+        result = self.test(stream=test_output_io, verbosity=verbosity)
         return result, test_output_io.getvalue()
 
     def _run_plan_tests(self, skip_tests: bool = False) -> t.Optional[ModelTextTestResult]:

sqlmesh/core/test/result.py

@@ -47,7 +47,7 @@ def addSubTest(
     def _print_char(self, char: str) -> None:
         from sqlmesh.core.console import TerminalConsole
 
-        if self.console and isinstance(self.console, TerminalConsole):
+        if isinstance(self.console, TerminalConsole):
             self.console._print(char, end="")
 
     def addFailure(self, test: unittest.TestCase, err: ErrorType) -> None: