Use SQLMeshError instead of NotImplementedError

erindru · erindru · commit f13a20e46c1c · 2025-06-19T21:50:06.000Z
diff --git a/sqlmesh/core/engine_adapter/base.py b/sqlmesh/core/engine_adapter/base.py
@@ -1222,15 +1222,15 @@ def create_catalog(self, catalog_name: str | exp.Identifier) -> None:
         return self._create_catalog(exp.parse_identifier(catalog_name, dialect=self.dialect))
 
     def _create_catalog(self, catalog_name: exp.Identifier) -> None:
-        raise NotImplementedError(
+        raise SQLMeshError(
             f"Unable to create catalog '{catalog_name.sql(dialect=self.dialect)}' as automatic catalog management is not implemented in the {self.dialect} engine."
         )
 
     def drop_catalog(self, catalog_name: str | exp.Identifier) -> None:
         return self._drop_catalog(exp.parse_identifier(catalog_name, dialect=self.dialect))
 
     def _drop_catalog(self, catalog_name: exp.Identifier) -> None:
-        raise NotImplementedError(
+        raise SQLMeshError(
             f"Unable to drop catalog '{catalog_name.sql(dialect=self.dialect)}' as automatic catalog management is not implemented in the {self.dialect} engine."
         )
 

Original file line number	Diff line number	Diff line change
`@@ -1222,15 +1222,15 @@ def create_catalog(self, catalog_name: str \| exp.Identifier) -> None:`
`1222`	`1222`	`return self._create_catalog(exp.parse_identifier(catalog_name, dialect=self.dialect))`
`1223`	`1223`
`1224`	`1224`	`def _create_catalog(self, catalog_name: exp.Identifier) -> None:`
`1225`		`- raise NotImplementedError(`
	`1225`	`+ raise SQLMeshError(`
`1226`	`1226`	`f"Unable to create catalog '{catalog_name.sql(dialect=self.dialect)}' as automatic catalog management is not implemented in the {self.dialect} engine."`
`1227`	`1227`	`)`
`1228`	`1228`
`1229`	`1229`	`def drop_catalog(self, catalog_name: str \| exp.Identifier) -> None:`
`1230`	`1230`	`return self._drop_catalog(exp.parse_identifier(catalog_name, dialect=self.dialect))`
`1231`	`1231`
`1232`	`1232`	`def _drop_catalog(self, catalog_name: exp.Identifier) -> None:`
`1233`		`- raise NotImplementedError(`
	`1233`	`+ raise SQLMeshError(`
`1234`	`1234`	`f"Unable to drop catalog '{catalog_name.sql(dialect=self.dialect)}' as automatic catalog management is not implemented in the {self.dialect} engine."`
`1235`	`1235`	`)`
`1236`	`1236`