temp [ci skip];

Author: benfdking

sqlmesh/lsp/api.py

@@ -9,6 +9,7 @@
 
 import typing as t
 from sqlmesh.utils.pydantic import PydanticModel
+from web.server.models import Model
 
 API_FEATURE = "sqlmesh/api"
 
@@ -28,7 +29,28 @@ class ApiRequest(PydanticModel):
 class ApiResponse(PydanticModel):
     """
     Response from the SQLMesh API.
-    This is a generic response that can be used to return data from any API endpoint.
+    This is a generic base class that can be used to return data from any API endpoint.
+    Specific API responses should inherit from this class and specify the data type more precisely.
     """
 
     data: t.Union[t.Dict[str, t.Any], t.List[t.Any]]
+
+
+class ApiResponseGetModels(ApiResponse):
+    """
+    Response from the SQLMesh API for the get_models endpoint.
+    Specifies the data type more precisely as a list of models.
+    """
+    data: t.List[Model]
+    
+    def __init__(self, **data):
+        # Convert datetime objects to strings before passing to parent constructor
+        if "data" in data and isinstance(data["data"], list):
+            for model in data["data"]:
+                if hasattr(model, "details") and model.details:
+                    # Convert datetime fields to None or string to avoid serialization issues
+                    for field in ["stamp", "start", "cron_prev", "cron_next"]:
+                        if hasattr(model.details, field) and getattr(model.details, field) is not None:
+                            setattr(model.details, field, None)
+        
+        super().__init__(**data)

sqlmesh/lsp/main.py

@@ -11,7 +11,7 @@
 from sqlmesh._version import __version__
 from sqlmesh.core.context import Context
 from sqlmesh.core.linter.definition import AnnotatedRuleViolation
-from sqlmesh.lsp.api import API_FEATURE, ApiRequest, ApiResponse
+from sqlmesh.lsp.api import API_FEATURE, ApiRequest, ApiResponse, ApiResponseGetModels
 from sqlmesh.lsp.completions import get_sql_completions
 from sqlmesh.lsp.context import LSPContext
 from sqlmesh.lsp.custom import ALL_MODELS_FEATURE, AllModelsRequest, AllModelsResponse
@@ -53,13 +53,13 @@ def all_models(
                 return get_sql_completions(None, params.textDocument.uri)
 
         @self.server.feature(API_FEATURE)
-        def api(ls: LanguageServer, request: ApiRequest) -> t.Dict[str, t.Any]:
+        def api(ls: LanguageServer, request: ApiRequest) -> ApiResponse:
             if self.lsp_context is None:
                 return ApiResponse(data={})
             if request.url == "/api/models":
-                response = ApiResponse(data=get_models(self.lsp_context.context))
-                return response.model_dump(mode='json')
-            return ApiResponse(data={}).model_dump(mode='json')
+                response = ApiResponseGetModels(data=get_models(self.lsp_context.context))
+                return response 
+            return ApiResponse(data={})
 
         @self.server.feature(types.TEXT_DOCUMENT_DID_OPEN)
         def did_open(