PR Feedback 2

Author: VaggelisD

sqlmesh/core/context.py

@@ -2460,13 +2460,13 @@ def lint_models(
     def load_model_tests(
         self, tests: t.Optional[t.List[str]] = None, patterns: list[str] | None = None
     ) -> t.List[ModelTestMetadata]:
-        # If a set of tests is provided, use a single loader to load them
-        # Otherwise, gather all tests from all loaders/repos
+        # If a set of specific test path(s) are provided, we can use a single loader
+        # since it's not required to walk every tests/ folder in each repo
         loaders = [self._loaders[0]] if tests else self._loaders
 
         model_tests = []
         for loader in loaders:
-            model_tests.extend(loader._load_model_tests(tests=tests, patterns=patterns))
+            model_tests.extend(loader.load_model_tests(tests=tests, patterns=patterns))
 
         return model_tests
 

sqlmesh/core/loader.py

@@ -293,7 +293,7 @@ def _load_linting_rules(self) -> RuleSet:
         """Loads user linting rules"""
         return RuleSet()
 
-    def _load_model_tests(
+    def load_model_tests(
         self, tests: t.Optional[t.List[str]] = None, patterns: list[str] | None = None
     ) -> t.List[ModelTestMetadata]:
         """Loads YAML-based model tests"""
@@ -699,21 +699,21 @@ def _load_model_test_file(self, path: Path) -> dict[str, ModelTestMetadata]:
 
         return model_test_metadata
 
-    def _load_model_tests(
+    def load_model_tests(
         self, tests: t.Optional[t.List[str]] = None, patterns: list[str] | None = None
     ) -> t.List[ModelTestMetadata]:
         """Loads YAML-based model tests"""
-        test_meta: t.List[ModelTestMetadata] = []
+        test_meta_list: t.List[ModelTestMetadata] = []
 
         if tests:
             for test in tests:
                 filename, test_name = test.split("::", maxsplit=1) if "::" in test else (test, "")
 
-                test_file = self._load_model_test_file(Path(filename))
+                test_meta = self._load_model_test_file(Path(filename))
                 if test_name:
-                    test_meta.append(test_file[test_name])
+                    test_meta_list.append(test_meta[test_name])
                 else:
-                    test_meta.extend(test_file.values())
+                    test_meta_list.extend(test_meta.values())
         else:
             search_path = Path(self.config_path) / c.TESTS
 
@@ -727,12 +727,12 @@ def _load_model_tests(
                 ):
                     continue
 
-                test_meta.extend(self._load_model_test_file(yaml_file).values())
+                test_meta_list.extend(self._load_model_test_file(yaml_file).values())
 
         if patterns:
-            test_meta = filter_tests_by_patterns(test_meta, patterns)
+            test_meta_list = filter_tests_by_patterns(test_meta_list, patterns)
 
-        return test_meta
+        return test_meta_list
 
     class _Cache(CacheBase):
         def __init__(self, loader: SqlMeshLoader, config_path: Path):

tests/core/test_test.py

@@ -2319,7 +2319,6 @@ def test_number_of_tests_found(tmp_path: Path) -> None:
         """
 test_example_full_model1:
   model: sqlmesh_example.full_model
-  description: This is an invalid test
   inputs:
     sqlmesh_example.incremental_model:
       rows:
@@ -2339,7 +2338,6 @@ def test_number_of_tests_found(tmp_path: Path) -> None:
         
 test_example_full_model2:
   model: sqlmesh_example.full_model
-  description: This is an invalid test
   inputs:
     sqlmesh_example.incremental_model:
       rows: