Skip to content

Commit c2a9695

Browse files
authored
chore: update eslint (#4280)
1 parent 64c3305 commit c2a9695

10 files changed

Lines changed: 118 additions & 1631 deletions

File tree

.circleci/continue_config.yml

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -96,31 +96,24 @@ jobs:
9696

9797
ui_style:
9898
docker:
99-
- image: cimg/python:3.9
99+
- image: cimg/node:20.19.0
100100
resource_class: small
101101
steps:
102102
- halt_unless_client
103103
- checkout
104-
- run:
105-
command: |
106-
cp .pre-commit-config.yaml pre-commit-cache-key.txt
107-
python --version --version >> pre-commit-cache-key.txt
108104
- restore_cache:
109105
keys:
110-
- v1-pc-cache-{{ checksum "pre-commit-cache-key.txt" }}
111-
- run:
112-
name: Install pre-commit
113-
command: pip install pre-commit
114-
- run:
115-
name: Fix Git URL override
116-
command: git config --global --unset url."ssh://git@github.com".insteadOf
106+
- v1-nm-cache-{{ checksum "package-lock.json" }}
117107
- run:
118-
name: Run linters and code style checks
119-
command: make ui-style
108+
name: Install packages
109+
command: npm ci
120110
- save_cache:
121-
key: v1-pc-cache-{{ checksum "pre-commit-cache-key.txt" }}
111+
key: v1-nm-cache-{{ checksum "package-lock.json" }}
122112
paths:
123-
- ~/.cache/pre-commit
113+
- /root/.npm
114+
- run:
115+
name: Run linters and code style checks
116+
command: npm run lint
124117

125118
ui_test:
126119
docker:

.pre-commit-config.yaml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -23,35 +23,3 @@ repos:
2323
files: *files
2424
require_serial: true
2525
exclude: ^(tests/fixtures)
26-
- repo: https://github.com/pre-commit/mirrors-prettier
27-
rev: "fc26039"
28-
hooks:
29-
- id: prettier
30-
name: prettier
31-
files: ^(web/client)
32-
entry: prettier --write --ignore-path web/client/.prettierignore
33-
exclude: ^(web/client/node_modules)
34-
require_serial: true
35-
language: node
36-
- repo: https://github.com/pre-commit/mirrors-eslint
37-
rev: "4620ec5"
38-
hooks:
39-
- id: eslint
40-
name: eslint
41-
files: ^(web/client)
42-
exclude: ^(web/client/node_modules)
43-
entry: eslint --fix
44-
additional_dependencies:
45-
[
46-
"@typescript-eslint/eslint-plugin@6.5.0",
47-
"@typescript-eslint/parser@6.5.0",
48-
eslint@8.48.0,
49-
eslint-config-prettier@9.0.0,
50-
eslint-config-standard-with-typescript@39.0.0,
51-
eslint-plugin-import@2.28.1,
52-
eslint-plugin-n@16.0.2,
53-
eslint-plugin-promise@6.1.1,
54-
eslint-plugin-react@7.33.2,
55-
]
56-
require_serial: true
57-
language: node

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ py-style:
1616
SKIP=prettier,eslint pre-commit run --all-files
1717

1818
ui-style:
19-
SKIP=ruff,ruff-format,mypy pre-commit run --all-files
19+
npm run lint
2020

2121
doc-test:
2222
python -m pytest --doctest-modules sqlmesh/core sqlmesh/utils

0 commit comments

Comments
 (0)