fix(vscode): use context manager for file opening in tests

Used 'with' statement to properly close file handle after reading.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: benfdking

sqlmesh/lsp/main.py

@@ -14,7 +14,10 @@
 from sqlmesh.lsp.completions import get_sql_completions
 from sqlmesh.lsp.context import LSPContext, ModelTarget
 from sqlmesh.lsp.custom import ALL_MODELS_FEATURE, AllModelsRequest, AllModelsResponse
-from sqlmesh.lsp.reference import get_model_definitions_for_a_path, filter_references_by_position
+from sqlmesh.lsp.reference import (
+    get_model_definitions_for_a_path,
+    filter_references_by_position,
+)
 
 
 class SQLMeshLanguageServer:
@@ -186,18 +189,10 @@ def goto_definition(
                 if self.lsp_context is None:
                     raise RuntimeError(f"No context found for document: {document.path}")
 
-                # Get all possible references
                 references = get_model_definitions_for_a_path(
                     self.lsp_context, params.text_document.uri
                 )
-                if not references:
-                    return []
-
-                # Filter references by cursor position
                 filtered_references = filter_references_by_position(references, params.position)
-                if not filtered_references:
-                    return []
-
                 return [
                     types.LocationLink(
                         target_uri=reference.uri,

tests/lsp/test_reference.py

@@ -130,7 +130,8 @@ def test_filter_references_by_position() -> None:
 
     # Get file contents to locate positions for testing
     path = waiter_revenue_by_day_uri.removeprefix("file://")
-    read_file = open(path, "r").readlines()
+    with open(path, "r") as file:
+        read_file = file.readlines()
 
     # Test positions for each reference
     for i, reference in enumerate(all_references):