Skip to content

Commit ac25787

Browse files
authored
chore: make check status message clearer (#4507)
1 parent a58a59f commit ac25787

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

sqlmesh/integrations/github/cicd/command.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def check_required_approvers(ctx: click.Context) -> None:
5555
"""Checks if a required approver has provided approval on the PR."""
5656
if not _check_required_approvers(ctx.obj["github"]):
5757
raise CICDBotError(
58-
"Required approver has not approved the PR. See check status for more information."
58+
"Required approver has not approved the PR. See Pull Requests Checks for more information."
5959
)
6060

6161

@@ -105,7 +105,7 @@ def _run_linter(controller: GithubController) -> bool:
105105
def run_tests(ctx: click.Context) -> None:
106106
"""Runs the unit tests"""
107107
if not _run_tests(ctx.obj["github"]):
108-
raise CICDBotError("Failed to run tests. See check status for more information.")
108+
raise CICDBotError("Failed to run tests. See Pull Requests Checks for more information.")
109109

110110

111111
def _update_pr_environment(controller: GithubController) -> bool:
@@ -132,7 +132,7 @@ def update_pr_environment(ctx: click.Context) -> None:
132132
"""Creates or updates the PR environments"""
133133
if not _update_pr_environment(ctx.obj["github"]):
134134
raise CICDBotError(
135-
"Failed to update PR environment. See check status for more information."
135+
"Failed to update PR environment. See Pull Requests Checks for more information."
136136
)
137137

138138

@@ -164,7 +164,7 @@ def gen_prod_plan(ctx: click.Context) -> None:
164164
controller.update_prod_plan_preview_check(status=GithubCheckStatus.IN_PROGRESS)
165165
if not _gen_prod_plan(controller):
166166
raise CICDBotError(
167-
"Failed to generate production plan. See check status for more information."
167+
"Failed to generate production plan. See Pull Requests Checks for more information."
168168
)
169169

170170

@@ -203,7 +203,9 @@ def _deploy_production(controller: GithubController) -> bool:
203203
def deploy_production(ctx: click.Context) -> None:
204204
"""Deploys the production environment"""
205205
if not _deploy_production(ctx.obj["github"]):
206-
raise CICDBotError("Failed to deploy to production. See check status for more information.")
206+
raise CICDBotError(
207+
"Failed to deploy to production. See Pull Requests Checks for more information."
208+
)
207209

208210

209211
def _run_all(controller: GithubController) -> None:
@@ -256,7 +258,9 @@ def _run_all(controller: GithubController) -> None:
256258
skip_reason="Linter or Unit Test(s) failed so skipping deploying to production",
257259
)
258260

259-
raise CICDBotError("Linter or Unit Test(s) failed. See check status for more information.")
261+
raise CICDBotError(
262+
"Linter or Unit Test(s) failed. See Pull Requests Checks for more information."
263+
)
260264

261265
pr_environment_updated = _update_pr_environment(controller)
262266
prod_plan_generated = False
@@ -295,7 +299,7 @@ def _run_all(controller: GithubController) -> None:
295299
or (has_required_approval and controller.pr_targets_prod_branch and not deployed_to_prod)
296300
):
297301
raise CICDBotError(
298-
"A step of the run-all check failed. See check status for more information."
302+
"A step of the run-all check failed. See Pull Requests Checks for more information."
299303
)
300304

301305

0 commit comments

Comments
 (0)