remove table_exist and columns

Author: fresioAS

sqlmesh/core/engine_adapter/fabric.py

@@ -20,87 +20,6 @@ class FabricAdapter(MSSQLEngineAdapter):
     SUPPORTS_TRANSACTIONS = False
     INSERT_OVERWRITE_STRATEGY = InsertOverwriteStrategy.DELETE_INSERT
 
-    def table_exists(self, table_name: TableName) -> bool:
-        """
-        Checks if a table exists.
-
-        Querying the uppercase `INFORMATION_SCHEMA` required
-        by case-sensitive Fabric environments.
-        """
-        table = exp.to_table(table_name)
-        sql = (
-            exp.select("1")
-            .from_("INFORMATION_SCHEMA.TABLES")
-            .where(f"TABLE_NAME = '{table.alias_or_name}'")
-        )
-        database_name = table.db
-        if database_name:
-            sql = sql.where(f"TABLE_SCHEMA = '{database_name}'")
-
-        result = self.fetchone(sql, quote_identifiers=True)
-
-        return result[0] == 1 if result else False
-
-    def columns(
-        self,
-        table_name: TableName,
-        include_pseudo_columns: bool = True,
-    ) -> t.Dict[str, exp.DataType]:
-        """Fabric doesn't support describe so we query INFORMATION_SCHEMA."""
-
-        table = exp.to_table(table_name)
-
-        sql = (
-            exp.select(
-                "COLUMN_NAME",
-                "DATA_TYPE",
-                "CHARACTER_MAXIMUM_LENGTH",
-                "NUMERIC_PRECISION",
-                "NUMERIC_SCALE",
-            )
-            .from_("INFORMATION_SCHEMA.COLUMNS")
-            .where(f"TABLE_NAME = '{table.name}'")
-        )
-        database_name = table.db
-        if database_name:
-            sql = sql.where(f"TABLE_SCHEMA = '{database_name}'")
-
-        columns_raw = self.fetchall(sql, quote_identifiers=True)
-
-        def build_var_length_col(
-            column_name: str,
-            data_type: str,
-            character_maximum_length: t.Optional[int] = None,
-            numeric_precision: t.Optional[int] = None,
-            numeric_scale: t.Optional[int] = None,
-        ) -> tuple:
-            data_type = data_type.lower()
-            if (
-                data_type in self.VARIABLE_LENGTH_DATA_TYPES
-                and character_maximum_length is not None
-                and character_maximum_length > 0
-            ):
-                return (column_name, f"{data_type}({character_maximum_length})")
-            if (
-                data_type in ("varbinary", "varchar", "nvarchar")
-                and character_maximum_length is not None
-                and character_maximum_length == -1
-            ):
-                return (column_name, f"{data_type}(max)")
-            if data_type in ("decimal", "numeric"):
-                return (column_name, f"{data_type}({numeric_precision}, {numeric_scale})")
-            if data_type == "float":
-                return (column_name, f"{data_type}({numeric_precision})")
-
-            return (column_name, data_type)
-
-        columns = [build_var_length_col(*row) for row in columns_raw]
-
-        return {
-            column_name: exp.DataType.build(data_type, dialect=self.dialect)
-            for column_name, data_type in columns
-        }
-
     def _insert_overwrite_by_condition(
         self,
         table_name: TableName,

tests/core/engine_adapter/test_fabric.py

@@ -53,7 +53,9 @@ def test_table_exists(adapter: FabricAdapter):
     assert not adapter.table_exists("db.table")
 
 
-def test_insert_overwrite_by_time_partition(adapter: FabricAdapter):
+def test_insert_overwrite_by_time_partition(
+    adapter: FabricAdapter, assert_exp_eq
+):  # Add assert_exp_eq fixture
     adapter.insert_overwrite_by_time_partition(
         "test_table",
         parse_one("SELECT a, b FROM tbl"),
@@ -64,11 +66,27 @@ def test_insert_overwrite_by_time_partition(adapter: FabricAdapter):
         columns_to_types={"a": exp.DataType.build("INT"), "b": exp.DataType.build("STRING")},
     )
 
-    # Fabric adapter should use DELETE/INSERT strategy, not MERGE.
-    assert to_sql_calls(adapter) == [
-        """DELETE FROM [test_table] WHERE [b] BETWEEN '2022-01-01' AND '2022-01-02';""",
-        """INSERT INTO [test_table] ([a], [b]) SELECT [a], [b] FROM (SELECT [a], [b] FROM [tbl]) AS [_subquery] WHERE [b] BETWEEN '2022-01-01' AND '2022-01-02';""",
-    ]
+    # Get the list of generated SQL strings
+    actual_sql_calls = to_sql_calls(adapter)
+
+    # There should be two calls: DELETE and INSERT
+    assert len(actual_sql_calls) == 2
+
+    # Assert the DELETE statement is correct (string comparison is fine for this simple one)
+    assert (
+        actual_sql_calls[0]
+        == "DELETE FROM [test_table] WHERE [b] BETWEEN '2022-01-01' AND '2022-01-02';"
+    )
+
+    # Assert the INSERT statement is semantically correct
+    expected_insert_sql = """
+        INSERT INTO [test_table] ([a], [b])
+        SELECT [a], [b] FROM (SELECT [a], [b] FROM [tbl]) AS [_subquery]
+        WHERE [b] BETWEEN '2022-01-01' AND '2022-01-02';
+    """
+
+    # Use assert_exp_eq to compare the parsed SQL expressions
+    assert_exp_eq(actual_sql_calls[1], expected_insert_sql)
 
 
 def test_replace_query(adapter: FabricAdapter):