chore(vscode): add banning of shadowing (#4240)

Author: benfdking

vscode/extension/eslint.config.mjs

@@ -23,6 +23,7 @@ export default [{
         curly: "error",
         eqeqeq: "error",
         "no-throw-literal": "error",
-        semi: ["error", "never"]
+        semi: ["error", "never"],
+        "no-shadow": "error",
     },
 }];

vscode/extension/src/extension.ts

@@ -69,8 +69,8 @@ export async function activate(context: vscode.ExtensionContext) {
   const restart = async () => {
     if (lspClient) {
       traceVerbose("Restarting LSP client")
-      const result = await lspClient.restart()
-      if (isErr(result)) {
+      const restartResult = await lspClient.restart()
+      if (isErr(restartResult)) {
         handleNotSginedInError(authProvider)
       }
     }

vscode/extension/src/utilities/common/settings.ts

@@ -34,8 +34,8 @@ function resolveVariables(value: string[], workspace?: WorkspaceFolder): string[
     })
 
     return value.map((s) => {
-        for (const [key, value] of substitutions) {
-            s = s.replace(key, value)
+        for (const [k, v] of substitutions) {
+            s = s.replace(k, v)
         }
         return s
     })