chore(vscode): further clean up of types (#4470)

Author: benfdking

vscode/react/src/components/graph/ModelLineageDetails.tsx

@@ -67,7 +67,7 @@ export default function ModelLineageDetails({
           className="mr-2 w-full whitespace-nowrap text-ellipsis overflow-hidden @lg:block font-bold text-neutral-600 dark:text-neutral-400 cursor-pointer hover:underline"
           onClick={handleCenter}
         >
-          {truncate(model.displayName, 50, 25)}
+          {truncate(model.name, 50, 25)}
         </a>
       )}
       <span className="bg-neutral-5 px-2 py-0.5 flex rounded-full mr-2">

vscode/react/src/components/graph/ModelNode.tsx

@@ -1,14 +1,13 @@
 import { isNil, isArrayNotEmpty, isNotNil, isFalse } from '@/utils/index'
 import clsx from 'clsx'
 import { useMemo, useCallback, useState } from 'react'
-import { ModelType } from '@/api/client'
+import { ModelType, type Model } from '@/api/client'
 import { useLineageFlow } from './context'
 import { type GraphNodeData } from './help'
 import { Position, type NodeProps } from 'reactflow'
 import { type Column } from '@/api/client'
 import ModelNodeHeaderHandles from './ModelNodeHeaderHandles'
 import ModelColumns from './ModelColumns'
-import type { Model } from '@/domain/model'
 
 export const EnumLineageNodeModelType = {
   ...ModelType,

vscode/react/src/components/graph/context.tsx

@@ -1,4 +1,4 @@
-import { type Column } from '@/api/client'
+import { type Column, type Model } from '@/api/client'
 import {
   createContext,
   useState,
@@ -11,7 +11,7 @@ import { EnumSide } from './types'
 import { type Node } from 'reactflow'
 import type { Lineage } from '@/domain/lineage'
 import type { ModelSQLMeshModel } from '@/domain/sqlmesh-model'
-import type { Model } from '@/domain/model'
+
 export interface Connections {
   left: string[]
   right: string[]

vscode/react/src/domain/model.ts

@@ -14,7 +14,7 @@ import { ModelSQLMeshModel } from '@/domain/sqlmesh-model'
 import { useEventBus } from '@/hooks/eventBus'
 import type { VSCodeEvent } from '@bus/callbacks'
 import { URI } from 'vscode-uri'
-import type { Model } from '@/domain/model'
+import type { Model } from '@/api/client'
 
 export function LineagePage() {
   const { emit } = useEventBus()
@@ -91,7 +91,6 @@ function Lineage() {
   }
   const modelsRecord = models.reduce(
     (acc, model) => {
-      // @ts-ignore
       acc[model.name] = model
       return acc
     },
@@ -130,7 +129,7 @@ export function LineageComponentFromWeb({
   function handleClickModel(id: string): void {
     console.log('handling click', id)
     const decodedId = decodeURIComponent(id)
-    const model = Object.values(models).find((m: Model) => m.fqn === decodedId)
+    const model = Object.values(models).find(m => m.fqn === decodedId)
     if (!model) {
       throw new Error('Model not found')
     }