chore: make path optional

- more correctly represent path being optional

Author: benfdking

sqlmesh/core/macros.py

@@ -171,7 +171,7 @@ def __init__(
         resolve_tables: t.Optional[t.Callable[[exp.Expression], exp.Expression]] = None,
         snapshots: t.Optional[t.Dict[str, Snapshot]] = None,
         default_catalog: t.Optional[str] = None,
-        path: Path = Path(),
+        path: t.Optional[Path] = None,
         environment_naming_info: t.Optional[EnvironmentNamingInfo] = None,
     ):
         self.dialect = dialect
@@ -1364,7 +1364,7 @@ def normalize_macro_name(name: str) -> str:
 def call_macro(
     func: t.Callable,
     dialect: DialectType,
-    path: Path,
+    path: t.Optional[Path],
     provided_args: t.Tuple[t.Any, ...],
     provided_kwargs: t.Dict[str, t.Any],
     **optional_kwargs: t.Any,
@@ -1411,7 +1411,7 @@ def _coerce(
     expr: t.Any,
     typ: t.Any,
     dialect: DialectType,
-    path: Path,
+    path: t.Optional[Path] = None,
     strict: bool = False,
 ) -> t.Any:
     """Coerces the given expression to the specified type on a best-effort basis."""

sqlmesh/core/model/definition.py

@@ -1635,6 +1635,8 @@ def is_seed(self) -> bool:
     def seed_path(self) -> Path:
         seed_path = Path(self.kind.path)
         if not seed_path.is_absolute():
+            if self._path is None:
+                raise SQLMeshError(f"Seed model '{self.name}' has no path")
             return self._path.parent / seed_path
         return seed_path
 
@@ -2000,7 +2002,7 @@ def load_sql_based_model(
     expressions: t.List[exp.Expression],
     *,
     defaults: t.Optional[t.Dict[str, t.Any]] = None,
-    path: Path = Path(),
+    path: t.Optional[Path] = None,
     module_path: Path = Path(),
     time_column_format: str = c.DEFAULT_TIME_COLUMN_FORMAT,
     macros: t.Optional[MacroRegistry] = None,
@@ -2143,6 +2145,8 @@ def load_sql_based_model(
     # The name of the model will be inferred from its path relative to `models/`, if it's not explicitly specified
     name = meta_fields.pop("name", "")
     if not name and infer_names:
+        if path is None:
+            raise ValueError("Model must have a name", path)
         name = get_model_name(path)
 
     if not name:
@@ -2546,7 +2550,7 @@ def _create_model(
 
 def _split_sql_model_statements(
     expressions: t.List[exp.Expression],
-    path: Path,
+    path: t.Optional[Path],
     dialect: t.Optional[str] = None,
 ) -> t.Tuple[
     t.Optional[exp.Expression],
@@ -2680,7 +2684,7 @@ def _refs_to_sql(values: t.Any) -> exp.Expression:
 def render_meta_fields(
     fields: t.Dict[str, t.Any],
     module_path: Path,
-    path: Path,
+    path: t.Optional[Path],
     jinja_macros: t.Optional[JinjaMacroRegistry],
     macros: t.Optional[MacroRegistry],
     dialect: DialectType,
@@ -2764,7 +2768,7 @@ def render_field_value(value: t.Any) -> t.Any:
 def render_model_defaults(
     defaults: t.Dict[str, t.Any],
     module_path: Path,
-    path: Path,
+    path: t.Optional[Path],
     jinja_macros: t.Optional[JinjaMacroRegistry],
     macros: t.Optional[MacroRegistry],
     dialect: DialectType,
@@ -2814,7 +2818,7 @@ def parse_defaults_properties(
 def render_expression(
     expression: exp.Expression,
     module_path: Path,
-    path: Path,
+    path: t.Optional[Path],
     jinja_macros: t.Optional[JinjaMacroRegistry] = None,
     macros: t.Optional[MacroRegistry] = None,
     dialect: DialectType = None,

sqlmesh/core/node.py

@@ -196,7 +196,7 @@ class _Node(PydanticModel):
     interval_unit_: t.Optional[IntervalUnit] = Field(alias="interval_unit", default=None)
     tags: t.List[str] = []
     stamp: t.Optional[str] = None
-    _path: Path = Path()
+    _path: t.Optional[Path] = Path()
     _data_hash: t.Optional[str] = None
     _metadata_hash: t.Optional[str] = None
 

sqlmesh/core/renderer.py

@@ -43,7 +43,7 @@ def __init__(
         expression: exp.Expression,
         dialect: DialectType,
         macro_definitions: t.List[d.MacroDef],
-        path: Path = Path(),
+        path: t.Optional[Path] = None,
         jinja_macro_registry: t.Optional[JinjaMacroRegistry] = None,
         python_env: t.Optional[t.Dict[str, Executable]] = None,
         only_execution_time: bool = False,

sqlmesh/core/snapshot/definition.py

@@ -2168,7 +2168,7 @@ def _check_ready_intervals(
     context: ExecutionContext,
     python_env: t.Dict[str, Executable],
     dialect: DialectType = None,
-    path: Path = Path(),
+    path: t.Optional[Path] = None,
     kwargs: t.Optional[t.Dict] = None,
 ) -> Intervals:
     checked_intervals: Intervals = []

sqlmesh/lsp/reference.py

@@ -132,6 +132,8 @@ def get_model_definitions_for_a_path(
     if len(tables) == 0:
         return []
 
+    if file_path is None:
+        return []
     with open(file_path, "r", encoding="utf-8") as file:
         read_file = file.readlines()
 
@@ -161,7 +163,7 @@ def get_model_definitions_for_a_path(
             continue
         referenced_model_path = referenced_model._path
         # Check whether the path exists
-        if not referenced_model_path.is_file():
+        if not referenced_model_path or not referenced_model_path.is_file():
             continue
         referenced_model_uri = f"file://{referenced_model_path}"
 

sqlmesh/magics.py

@@ -229,8 +229,9 @@ def model(self, context: Context, line: str, sql: t.Optional[str] = None) -> Non
             if loaded.name == args.model:
                 model = loaded
         else:
-            with open(model._path, "r", encoding="utf-8") as file:
-                expressions = parse(file.read(), default_dialect=config.dialect)
+            if model._path:
+                with open(model._path, "r", encoding="utf-8") as file:
+                    expressions = parse(file.read(), default_dialect=config.dialect)
 
         formatted = format_model_expressions(
             expressions,
@@ -249,8 +250,9 @@ def model(self, context: Context, line: str, sql: t.Optional[str] = None) -> Non
             replace=True,
         )
 
-        with open(model._path, "w", encoding="utf-8") as file:
-            file.write(formatted)
+        if model._path:
+            with open(model._path, "w", encoding="utf-8") as file:
+                file.write(formatted)
 
         if sql:
             context.console.log_success(f"Model `{args.model}` updated")

web/server/api/endpoints/models.py

@@ -124,8 +124,8 @@ def serialize_model(context: Context, model: Model, render_query: bool = False)
     return models.Model(
         name=model.name,
         fqn=model.fqn,
-        path=str(model._path.absolute().relative_to(context.path)),
-        full_path=str(model._path.absolute()),
+        path=str(model._path.absolute().relative_to(context.path)) if model._path else None,
+        full_path=str(model._path.absolute()) if model._path else None,
         dialect=dialect,
         columns=columns,
         details=details,

web/server/settings.py

@@ -80,7 +80,7 @@ def _get_loaded_context(path: str | Path, config: str, gateway: str) -> Context:
 
 @lru_cache()
 def _get_path_to_model_mapping(context: Context) -> dict[Path, Model]:
-    return {model._path: model for model in context._models.values()}
+    return {model._path: model for model in context._models.values() if model._path}
 
 
 def get_path_to_model_mapping(