chore(vscode): make eslint stricter (#4287)

Author: benfdking

.circleci/continue_config.yml

@@ -43,7 +43,6 @@ jobs:
       - run:
           name: Install VSCode extension dependencies
           command: |
-            cd vscode/extension
             npm ci
       - run:
           name: Run VSCode extension CI

package-lock.json

@@ -1,35 +1,28 @@
-import typescriptEslint from '@typescript-eslint/eslint-plugin'
-import tsParser from '@typescript-eslint/parser'
+import eslint from '@eslint/js'
+import tseslint from 'typescript-eslint'
 
-export default [
+export default tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.strict,
+  tseslint.configs.stylistic,
+  tseslint.configs.recommendedTypeChecked,
   {
-    files: ['**/*.ts'],
-  },
-  {
-    plugins: {
-      '@typescript-eslint': typescriptEslint,
-    },
-
     languageOptions: {
-      parser: tsParser,
-      ecmaVersion: 2022,
-      sourceType: 'module',
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
     },
-
+  },
+  {
     rules: {
-      '@typescript-eslint/naming-convention': [
-        'warn',
-        {
-          selector: 'import',
-          format: ['camelCase', 'PascalCase'],
-        },
-      ],
-
-      curly: 'error',
-      eqeqeq: 'error',
-      'no-throw-literal': 'error',
-      semi: ['error', 'never'],
-      'no-shadow': 'error',
+      '@typescript-eslint/switch-exhaustiveness-check': 'error',
+      '@typescript-eslint/no-unsafe-assignment': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'off',
+      '@typescript-eslint/restrict-template-expressions': 'off',
+      '@typescript-eslint/no-unsafe-argument': 'off',
+      '@typescript-eslint/no-unsafe-member-access': 'off',
     },
   },
-]
+)

vscode/extension/eslint.config.mjs

@@ -87,14 +87,13 @@
     "@types/mocha": "^10.0.10",
     "@types/node": "20.11.25",
     "@types/vscode": "1.96.0",
-    "@typescript-eslint/eslint-plugin": "^8.28.0",
-    "@typescript-eslint/parser": "^8.28.0",
     "@vscode/test-cli": "^0.0.10",
     "@vscode/test-electron": "^2.4.1",
     "@vscode/vsce": "^3.3.2",
     "esbuild": "^0.25.2",
     "eslint": "^9.23.0",
     "ts-loader": "^9.5.2",
-    "typescript": "^5.8.2"
+    "typescript": "^5.8.2",
+    "typescript-eslint": "^8.31.1"
   }
 }

vscode/extension/package.json

@@ -82,7 +82,7 @@ export class AuthenticationProviderTobikoCloud
       return err('Failed to get tcloud auth status')
     }
     const status = result.stdout
-    const statusToJson = JSON.parse(status)
+    const statusToJson: any = JSON.parse(status)
     const statusResponse = statusResponseSchema.parse(statusToJson)
     return ok(statusResponse)
   }
@@ -188,7 +188,7 @@ export class AuthenticationProviderTobikoCloud
     }
 
     try {
-      const resultToJson = JSON.parse(result.stdout)
+      const resultToJson: any = JSON.parse(result.stdout)
       const urlCode = loginUrlResponseSchema.parse(resultToJson)
       const url = urlCode.url
 
@@ -197,7 +197,12 @@ export class AuthenticationProviderTobikoCloud
       }
 
       const ac = new AbortController()
-      const timeout = setTimeout(() => ac.abort(), 1000 * 60 * 5)
+      const timeout = setTimeout(
+        () => {
+          ac.abort()
+        },
+        1000 * 60 * 5,
+      )
       const backgroundServerForLogin = execAsync(
         tcloudBinPath,
         ['auth', 'vscode', 'start-server', urlCode.verifier_code],
@@ -279,11 +284,16 @@ export class AuthenticationProviderTobikoCloud
     }
 
     try {
-      const resultToJson = JSON.parse(result.stdout)
+      const resultToJson: any = JSON.parse(result.stdout)
       const deviceCodeResponse = deviceCodeResponseSchema.parse(resultToJson)
 
       const ac = new AbortController()
-      const timeout = setTimeout(() => ac.abort(), 1000 * 60 * 5)
+      const timeout = setTimeout(
+        () => {
+          ac.abort()
+        },
+        1000 * 60 * 5,
+      )
       const waiting = execAsync(
         tcloudBinPath,
         ['auth', 'vscode', 'poll_device', deviceCodeResponse.device_code],

vscode/extension/src/auth/auth.ts

@@ -12,7 +12,7 @@ export const format =
     const out = await internalFormat()
     if (isErr(out)) {
       if (out.error.type === 'not_signed_in') {
-        handleNotSginedInError(authProvider)
+        await handleNotSginedInError(authProvider)
         return
       } else {
         vscode.window.showErrorMessage(

vscode/extension/src/commands/format.ts

@@ -58,7 +58,7 @@ export async function activate(context: vscode.ExtensionContext) {
   lspClient = new LSPClient()
   const result = await lspClient.start()
   if (isErr(result)) {
-    handleNotSginedInError(authProvider)
+    await handleNotSginedInError(authProvider)
   }
   context.subscriptions.push(lspClient)
 
@@ -67,7 +67,7 @@ export async function activate(context: vscode.ExtensionContext) {
       traceVerbose('Restarting LSP client')
       const restartResult = await lspClient.restart()
       if (isErr(restartResult)) {
-        handleNotSginedInError(authProvider)
+        await handleNotSginedInError(authProvider)
       }
     }
   }

vscode/extension/src/extension.ts

@@ -27,7 +27,7 @@ export class LSPClient implements Disposable {
 
     const sqlmesh = await sqlmesh_lsp_exec()
     if (isErr(sqlmesh)) {
-      traceError(`Failed to get sqlmesh_lsp_exec: ${sqlmesh.error}`)
+      traceError(`Failed to get sqlmesh_lsp_exec, ${sqlmesh.error.type}`)
       return sqlmesh
     }
     const workspaceFolders = getWorkspaceFolders()
@@ -41,9 +41,9 @@ export class LSPClient implements Disposable {
       })
     }
 
-    let folder = workspaceFolders[0]
+    const folder = workspaceFolders[0]
     const workspacePath = workspaceFolders[0].uri.fsPath
-    let serverOptions: ServerOptions = {
+    const serverOptions: ServerOptions = {
       run: {
         command: sqlmesh.value.bin,
         transport: TransportKind.stdio,
@@ -61,7 +61,7 @@ export class LSPClient implements Disposable {
         args: sqlmesh.value.args,
       },
     }
-    let clientOptions: LanguageClientOptions = {
+    const clientOptions: LanguageClientOptions = {
       documentSelector: [{ scheme: 'file', pattern: `**/*.sql` }],
       workspaceFolder: folder,
       diagnosticCollectionName: 'sqlmesh',

vscode/extension/src/lsp/lsp.ts

@@ -35,9 +35,9 @@ export function registerCommand(
 export const { onDidChangeConfiguration } = workspace
 
 export function isVirtualWorkspace(): boolean {
-  const isVirtual =
-    workspace.workspaceFolders &&
-    workspace.workspaceFolders.every(f => f.uri.scheme !== 'file')
+  const isVirtual = workspace.workspaceFolders?.every(
+    f => f.uri.scheme !== 'file',
+  )
   return !!isVirtual
 }
 

vscode/extension/src/utilities/common/vscodeapi.ts

@@ -58,8 +58,9 @@ export function execAsync(
       options.signal.addEventListener('abort', onAbort, { once: true })
 
       // Clean‑up the event listener when the promise settles
-      const cleanup = () =>
+      const cleanup = () => {
         options.signal!.removeEventListener('abort', onAbort)
+      }
       child.once('exit', cleanup)
       child.once('error', cleanup)
     }