Refactor to _cells_match and simplify logic

Author: themisvaltinos

sqlmesh/core/console.py

@@ -1908,7 +1908,7 @@ def show_row_diff(
                     # Filter to retain non identical-valued rows
                     column_table = column_table[
                         column_table.apply(
-                            lambda row: _compare_df_cells(row[source_column], row[target_column]),
+                            lambda row: not _cells_match(row[source_column], row[target_column]),
                             axis=1,
                         )
                     ]
@@ -2042,23 +2042,16 @@ def show_linter_violations(
             self.log_warning(msg)
 
 
-def _compare_df_cells(x: t.Any, y: t.Any) -> bool:
-    """Helper function to compare two cells and returns true if they're not equal, handling array objects."""
+def _cells_match(x: t.Any, y: t.Any) -> bool:
+    """Helper function to compare two cells and returns true if they're equal, handling array objects."""
     if x is None or y is None:
-        return x != y
+        return x == y
 
-    # Convert any array-like object to list for consistent comparison
-    def to_list(val: t.Any) -> t.Any:
-        return list(val) if isinstance(val, (pd.Series, np.ndarray, list, tuple, set)) else val
+    # Convert array-like objects to list for consistent comparison
+    def _normalize(val: t.Any) -> t.Any:
+        return list(val) if isinstance(val, (pd.Series, np.ndarray)) else val
 
-    x = to_list(x)
-    y = to_list(y)
-    if isinstance(x, list) and isinstance(y, list):
-        if len(x) != len(y):
-            return True
-        return any(a != b for a, b in zip(x, y))
-
-    return x != y
+    return _normalize(x) == _normalize(y)
 
 
 def add_to_layout_widget(target_widget: LayoutWidget, *widgets: widgets.Widget) -> LayoutWidget: