chore(vscode): further type correcting (#4475)

Author: benfdking

vscode/react/src/components/graph/ModelColumns.tsx

@@ -702,7 +702,6 @@ function ColumnSource({
       />
       <Transition
         show={isShowing}
-        // @ts-ignore
         as={Fragment}
         enter="transition ease-out duration-200"
         enterFrom="opacity-0 -translate-y-[40%]"

vscode/react/src/components/graph/ModelLineage.tsx

@@ -84,8 +84,7 @@ export function ModelLineage({
   >(undefined)
 
   useEffect(() => {
-    // @ts-ignore
-    const lineageWorker = createLineageWorker()
+    const lineageWorker = new createLineageWorker()
 
     lineageWorker.addEventListener('message', handleLineageWorkerMessage)
 
@@ -119,8 +118,6 @@ export function ModelLineage({
       })
 
     return () => {
-      // void cancel?.()
-
       lineageWorker.removeEventListener('message', handleLineageWorkerMessage)
       lineageWorker.terminate()
 
@@ -140,7 +137,6 @@ export function ModelLineage({
       }
     })
 
-    // @ts-ignore
     setUnknownModels(new Set(unknownModels))
   }, [modelLineage, models])
 

vscode/react/src/components/graph/context.tsx

@@ -161,7 +161,6 @@ export default function LineageFlowProvider({
     () =>
       getNodeMap({
         lineage,
-        // @ts-ignore
         models,
         unknownModels,
         withColumns,

vscode/react/src/components/graph/help.ts

@@ -7,7 +7,7 @@ import {
   isObjectEmpty,
   toID,
 } from '@/utils/index'
-import { type LineageColumn, type Column } from '@/api/client'
+import { type LineageColumn, type Column, type Model } from '@/api/client'
 import { Position, type Edge, type Node, type XYPosition } from 'reactflow'
 import { type ActiveEdges, type Connections } from './context'
 import { EnumSide } from './types'
@@ -17,7 +17,6 @@ import {
 } from './ModelNode'
 import type { Lineage } from '@/domain/lineage'
 import type { ConnectedNode } from '@/workers/lineage'
-import type { ModelSQLMeshModel } from '@/domain/sqlmesh-model'
 
 export interface GraphNodeData {
   label: string
@@ -102,7 +101,6 @@ function getEdges(lineage: Record<string, Lineage> = {}): Edge[] {
   for (const targetModelName of modelNames) {
     const targetModel = lineage[targetModelName]!
 
-    // @ts-ignore
     targetModel.models.forEach(sourceModelName => {
       outputEdges.push(createGraphEdge(sourceModelName, targetModelName))
     })
@@ -156,7 +154,7 @@ function getNodeMap({
   unknownModels,
   withColumns,
 }: {
-  models: Map<string, ModelSQLMeshModel>
+  models: Record<string, Model>
   withColumns: boolean
   unknownModels: Set<string>
   lineage?: Record<string, Lineage>
@@ -172,9 +170,9 @@ function getNodeMap({
   const modelNames = Object.keys(lineage)
 
   return modelNames.reduce((acc: Record<string, Node>, modelName: string) => {
-    // @ts-ignore
     const model = models[modelName]
     const node = createGraphNode(modelName, {
+      // @ts-ignore
       label: model?.displayName ?? modelName,
       withColumns,
       type: isNotNil(model)
@@ -188,8 +186,7 @@ function getNodeMap({
           : EnumLineageNodeModelType.cte,
     })
     const columnsCount = withColumns
-      ? // @ts-ignore
-        (models[modelName]?.columns?.length ?? 0)
+      ? (models[modelName]?.columns?.length ?? 0)
       : 0
 
     const maxWidth = Math.min(
@@ -218,7 +215,6 @@ function getNodeMap({
 
   function getNodeMaxWidth(label: string, hasColumns: boolean = false): number {
     const defaultWidth = label.length * CHAR_WIDTH
-    // @ts-ignore
     const columns = models[label]?.columns ?? []
 
     return hasColumns
@@ -369,7 +365,6 @@ function mergeLineageWithColumns(
                   newLineageModelColumnModel,
                 ),
           ),
-          // @ts-ignore
         ).map(encodeURI)
       }
     }
@@ -476,7 +471,6 @@ function getLineageIndex(lineage: Record<string, Lineage> = {}): string {
       const { models = [], columns = {} } = lineage[key]!
       const allModels = new Set<string>()
 
-      // @ts-ignore
       models.forEach(m => allModels.add(m))
 
       if (isNotNil(columns)) {

vscode/react/src/hooks/eventBus.tsx

@@ -84,20 +84,3 @@ export function useEvent<K extends keyof EventMap>(
     return unsub // unsubscribe on unmount
   }, [bus, type])
 }
-
-/**
- * 5️⃣ Example usage:
- *
- * // index.tsx
- * <EventBusProvider>
- *   <App />
- * </EventBusProvider>
- *
- * // Any deep component
- * const bus = useEventBus();
- * bus.emit('cart:add', { productId: 'sku123', qty: 2 });
- *
- * useEvent('user:login', ({ id }) => {
- *   console.log('Logged in', id);
- * });
- */

vscode/react/src/pages/lineage.tsx

@@ -100,7 +100,7 @@ function Lineage() {
   on('changeFocusedFile', fileUri => {
     const full_path = URI.parse(fileUri.fileUri).fsPath
     const model = Object.values(modelsRecord).find(
-      (m: Model) => m.full_path === full_path,
+      m => m.full_path === full_path,
     )
     if (model) {
       setSelectedModelSet(model.name)

vscode/react/src/utils/vscodeapi.ts

@@ -13,7 +13,6 @@ export const sendVSCodeMessage = <K extends keyof Callback>(
     key: callbackName,
     payload: payload,
   }
-  console.log('sending message to self', eventPayload)
   getVSCodeAPI().postMessage(eventPayload)
 }